Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ruff in pre-commit for linting and formatting #1314

Merged
merged 5 commits into from
Sep 8, 2024
Merged

use ruff in pre-commit for linting and formatting #1314

merged 5 commits into from
Sep 8, 2024

Conversation

lbbrhzn
Copy link
Owner

@lbbrhzn lbbrhzn commented Sep 8, 2024

use ruff for linting and formatting
includes fixes for ruff linting errors
includes updates setting for visual studio code

@lbbrhzn lbbrhzn temporarily deployed to continuous-integration September 8, 2024 15:20 — with GitHub Actions Inactive
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (4b06be7) to head (8bd0ac1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           9        9           
  Lines        1391     1391           
=======================================
  Hits         1326     1326           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbbrhzn lbbrhzn requested a review from drc38 September 8, 2024 15:23
@lbbrhzn lbbrhzn temporarily deployed to continuous-integration September 8, 2024 15:37 — with GitHub Actions Inactive
@lbbrhzn lbbrhzn temporarily deployed to continuous-integration September 8, 2024 15:42 — with GitHub Actions Inactive
@lbbrhzn lbbrhzn temporarily deployed to continuous-integration September 8, 2024 15:46 — with GitHub Actions Inactive
Copy link
Collaborator

@drc38 drc38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@drc38
Copy link
Collaborator

drc38 commented Sep 8, 2024

Black, flake etc can be removed from workflows too

@lbbrhzn lbbrhzn temporarily deployed to continuous-integration September 8, 2024 19:41 — with GitHub Actions Inactive
@lbbrhzn lbbrhzn merged commit 5bd31f7 into main Sep 8, 2024
8 checks passed
@lbbrhzn lbbrhzn deleted the ruff branch September 8, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants