Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bluesky-adaptive demo and execution engine #6

Merged
merged 20 commits into from
Jul 21, 2023
Merged

Add bluesky-adaptive demo and execution engine #6

merged 20 commits into from
Jul 21, 2023

Conversation

ronpandolfi
Copy link
Collaborator

No description provided.

maffettone
maffettone reviewed Jul 12, 2023
View reviewed changes
Copy link

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole this makes good sense to me. I left some comments on design and the document model for ask/tell.

tsuchinoko/execution/bluesky_adaptive.py Outdated Show resolved Hide resolved
tsuchinoko/execution/bluesky_adaptive.py Show resolved Hide resolved
tsuchinoko/execution/bluesky_adaptive.py Outdated Show resolved Hide resolved
@ronpandolfi
make TsuchinokoAgent abstract; return document dict in tell
b14b1b8
@ronpandolfi
prevent race condition when debugging experiment thread
9fcd897
@ronpandolfi
interpret axes for Image graphs
4d50ef0
@ronpandolfi
prevent unnecessary operations with stale data
98d130b
@ronpandolfi
insulate from graph compute errors; fix hyperparameter Parameters; ad…
6a7a0b1 
…d kwargs for initial data, acquisition functions, and GP options;
@ronpandolfi
recover from Agent restart; refactor message conflation; fix dummy va…
c497995 
…riance;
@ronpandolfi
suppress procedural errors normal for adaptive engine-based graphs
93ee2df
@ronpandolfi
add explicit event ignore
5382026
@ronpandolfi
add successful connection message
1f7ba1d
@ronpandolfi
add log message for stale data
f390414
@ronpandolfi
imageview ux improvements (y inversion, autorange, autohistrange)
5511d6a
@ronpandolfi
refactor TsuchinokoAgent to provide better abstraction for return doc…
ff5c749 
…uments
@ronpandolfi ronpandolfi marked this pull request as ready for review July 21, 2023 23:46
@ronpandolfi ronpandolfi merged commit 3030ee9 into master Jul 21, 2023
4 checks passed
@ronpandolfi ronpandolfi deleted the bluesky-adaptive branch July 21, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maffettone maffettone maffettone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronpandolfi @maffettone