Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue34 verification section #37

Merged
merged 52 commits into from
Sep 14, 2018
Merged

Issue34 verification section #37

merged 52 commits into from
Sep 14, 2018

Conversation

mwetter
Copy link
Member

@mwetter mwetter commented Sep 7, 2018

Todo:

  • correct Fig. 9.9: Modelica model that conducts the verification so that lines don't overlap
  • describe value of the unit conversion factor in where u is a unit conversion factor

mwetter and others added 30 commits June 24, 2018 12:00
@milicag
Copy link
Contributor

milicag commented Sep 12, 2018

@mwetter I've addressed the 2 remaining issue. I still need to move the example from issue29 branch to this branch. Please let me know if you notice anything else.

@milicag
Copy link
Contributor

milicag commented Sep 12, 2018

@mwetter I added the validation models, data trends and data conversion script to this branch under examples. I'm still testing the functionality at this new location.

@milicag
Copy link
Contributor

milicag commented Sep 12, 2018

@mwetter Please take a look at the validation example package. The data paths need to be edited, otherwise the Example models will not run - how do I make them relative?

@mwetter
Copy link
Member Author

mwetter commented Sep 13, 2018

@milicag : to load files in a portable way, use loadResources("modelica://...."). See for example the weather data reader validation cases.

@milicag
Copy link
Contributor

milicag commented Sep 13, 2018

That works, thanks. Pushed up changes.

@mwetter mwetter merged commit cd5c6e8 into master Sep 14, 2018
@mwetter mwetter deleted the issue34_verification_section branch September 14, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants