Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Rofi being drawn under fullscreen window #12

Closed
AndreaOrru opened this issue Oct 16, 2020 · 5 comments
Closed

[BUG] Rofi being drawn under fullscreen window #12

AndreaOrru opened this issue Oct 16, 2020 · 5 comments
Labels

Comments

@AndreaOrru
Copy link

Version

Version: 1.6.0-49-g74a157c6 (makepkg)

Configuration

https://paste.debian.net/hidden/6d72e681/

Launch Command

rofi -show drun

Steps to reproduce

  • Make a window full screen.
  • Launch rofi through a key binding.

What behaviour you see

  • Rofi stays hidden under the fullscreen window.

What behaviour you expect to see

  • Rofi is drawn as an overlay on top of the fullscreen window.
@AndreaOrru AndreaOrru added the bug label Oct 16, 2020
@AndreaOrru AndreaOrru changed the title [BUG] [BUG] Rofi being drawn below fullscreen window Oct 16, 2020
@AndreaOrru AndreaOrru changed the title [BUG] Rofi being drawn below fullscreen window [BUG] Rofi being drawn under fullscreen window Oct 16, 2020
@Xyene
Copy link

Xyene commented Oct 17, 2020

rofi draws on ZWLR_LAYER_SHELL_V1_LAYER_TOP, which renders under fullscreen views (swaywm/sway#3057). I believe ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY needs to be used to go over fullscreen views. mako for instance offers the layer as a config option.

The current behavior was added in #7. (It's unclear to me how rofi can get triggered from the lockscreen, since the lockscreen should be capturing all input.)

@lbonn
Copy link
Owner

lbonn commented Oct 18, 2020

Thanks for the clarification, I suspected something like that.
Not showing on top of full screen windows seems indeed worse than showing on top of lock screens, so I'll probably revert that.

Adding the layer as a config option is maybe another good approach.

lbonn added a commit that referenced this issue Oct 18, 2020
This reverts commit dc1b159.

Given the current options, it's probably better to show rofi on top of
lock screens than not show it on top of full screen windows.

Discussion:
#12
#7
@lbonn
Copy link
Owner

lbonn commented Oct 18, 2020

Reverted now

@travankor
Copy link

travankor commented Oct 18, 2020

The current behavior was added in #7. (It's unclear to me how rofi can get triggered from the lockscreen, since the lockscreen should be capturing all input.)

rofi -show run &; sleep 1; swaylock
Or wait for swayidle to lock while rofi is around.

See also: swaywm/swaylock#107

Also, I believe wofi and bemenu have TOP as default. Otherwise, you could technically execute an arbitrary command while the launcher is focused (despite being locked).

@markstos
Copy link

I'm in favor of rofi appearing on top of full-screen apps.

With sway, you have to explicitly add --locked to a bindsym directive to allow a shortcut to launch an app on the lockscreen. I don't see anyone would set Rofi to be launched over the lockscreen. If they do, well then they explicitity meant to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants