Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix first class $ref , fix #29 #35

Closed
wants to merge 4 commits into from

Conversation

rom1504
Copy link

@rom1504 rom1504 commented Sep 2, 2015

No description provided.

@rom1504 rom1504 mentioned this pull request Sep 2, 2015
rom1504 added a commit to PrismarineJS/minecraft-data that referenced this pull request Sep 2, 2015
@rom1504
Copy link
Author

rom1504 commented Sep 3, 2015

Ah I haven't seen the tests. Seems like this PR might require some more work (see https://rawgit.com/rom1504/docson/fix_first_class_ref/tests/test.html vs https://rawgit.com/lbovet/docson/master/tests/test.html ).

It works in the case I tested, but it seems it breaks in other cases, I'll fix that (and add a test for the case this PR fixes)

@rom1504
Copy link
Author

rom1504 commented Sep 3, 2015

I added a regression test, and remove the type functionnality that was indeed not valid as said in #29

@rom1504
Copy link
Author

rom1504 commented Sep 3, 2015

Ok, I fixed the nested ref test, you can see it works there http://rom1504.github.io/docson/tests/test.html (the gh-pages branch in my work is in sync with the fix_first_class_ref branch)

@rom1504
Copy link
Author

rom1504 commented Sep 3, 2015

@rom1504
Copy link
Author

rom1504 commented Sep 3, 2015

Not done yet, other members than $ref should be ignored, as said in #29

@rom1504
Copy link
Author

rom1504 commented Sep 3, 2015

Not sure this is valid, it is fairly useless without other properties next to the $ref, and that fix isn't quite clean (it should clone things and all). Closing.

@rom1504 rom1504 closed this Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant