-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix first class $ref , fix #29 #35
Conversation
e94b7fe
to
5b724bd
Compare
Ah I haven't seen the tests. Seems like this PR might require some more work (see https://rawgit.com/rom1504/docson/fix_first_class_ref/tests/test.html vs https://rawgit.com/lbovet/docson/master/tests/test.html ). It works in the case I tested, but it seems it breaks in other cases, I'll fix that (and add a test for the case this PR fixes) |
…, fix self-referencing schema (in meta-schema example)
I added a regression test, and remove the type functionnality that was indeed not valid as said in #29 |
Ok, I fixed the nested ref test, you can see it works there http://rom1504.github.io/docson/tests/test.html (the gh-pages branch in my work is in sync with the fix_first_class_ref branch) |
Not done yet, other members than |
Not sure this is valid, it is fairly useless without other properties next to the |
No description provided.