Removes retain cycle prevention #106
Conversation
On September 18th, code was added with the aim of preventing a retain cycle. This code inadvertantly creates a crash if the user has denied photo access and the user dismisses the action sheet. It has to do with setting `actions = nil` in SheetController.
|
@steam Looking good! I think it would be better to just set the actions to nil directly, don't you think? |
The underlying issue turns out to be related to a well documented behavior in PHCachingImageManager - http://stackoverflow.com/questions/33266346/photos-framework-crash-this-application-is-not-allowed-to-access-photo-data. TL;DR - apps crash when a PHCachingImageManager is deallocated if it was created and access to the user’s photos are denied. Nice find @colinta 🤘.
| @@ -31,13 +31,19 @@ public enum ImagePickerMediaType { | |||
|
|
|||
| } | |||
|
|
|||
| fileprivate let imageManager = PHCachingImageManager() | |||
There was a problem hiding this comment.
@lbrndnr This is the crux of the problem/bug-fix. When this object is deallocated, if permission to photos has not been given, apple issues an exception of "permission not given". Thanks apple!
There was a problem hiding this comment.
The underlying issue turns out to be related to a well documented behavior in PHCachingImageManager - http://stackoverflow.com/questions/33266346/photos-framework-crash-this-application-is-not-allowed-to-access-photo-data. Nice find @colinta 🤘.
This should prevent the crash for all users. We plan to go a step further and guard against displaying the picker when the user has denied access to the photos library. We'll display a message to the user directing them to make the change in their settings.
On September 18th, code was added with the aim of preventing a retain cycle. This code inadvertantly creates a crash if the user has denied photo access and the user dismisses the action sheet. It has to do with setting
actions = nilin SheetController.