Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: relax dust thrashold to 1000 dewies/kB, which aligns to lbrycrd #92

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

roylee17
Copy link
Collaborator

@roylee17 roylee17 commented Sep 1, 2022

An output is considered dust if the cost to the network to spend the
coins is more than 1/3 of the minimum free transaction relay fee, which
has a default rate of 1000 satoshis/kb

bitcoind refactored dust threshold calculation, which removed the
multiply factor of 3 from the code, but increased the DUST_RELAY_TX_FEE
from 1000 to 3000 (satoshi/kb).

lbrycrd adopted the refactored code but also kept the rate to
1000 dewies/kB, which means:

An output is considered dust if the cost to the network to spend the
coins is more than the minimum free transaction relay fee.

This commit updates lbcd to align the policy.

@roylee17
Copy link
Collaborator Author

roylee17 commented Sep 1, 2022

@roylee17 roylee17 force-pushed the relax-dust-thrashold-to-1000-dewies-per-kb branch from 363b1af to a867cd5 Compare September 1, 2022 22:14
@roylee17
Copy link
Collaborator Author

roylee17 commented Sep 1, 2022

Fix #89

@coveralls
Copy link

coveralls commented Sep 1, 2022

Pull Request Test Coverage Report for Build 2975325203

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 51.653%

Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 65.36%
peer/peer.go 8 76.31%
Totals Coverage Status
Change from base Build 2968257507: 0.01%
Covered Lines: 22486
Relevant Lines: 43533

💛 - Coveralls

An output is considered dust if the cost to the network to spend the
coins is more than 1/3 of the minimum free transaction relay fee, which
has a default rate of 1000 satoshis/kb

bitcoind refactored dust threshold calculation, which removed the
multiply factor of 3 from the code, but increased the DUST_RELAY_TX_FEE
from 1000 to 3000 (satoshi/kb).

lbrycrd adopted the refactored code but also kept the rate to
1000 dewies/kB, which means:

    An output is considered dust if the cost to the network to spend the
    coins is more than the minimum free transaction relay fee.
@roylee17 roylee17 force-pushed the relax-dust-thrashold-to-1000-dewies-per-kb branch from a867cd5 to 363dd1d Compare September 1, 2022 22:20
@roylee17 roylee17 merged commit 8a80f06 into master Sep 1, 2022
@roylee17 roylee17 deleted the relax-dust-thrashold-to-1000-dewies-per-kb branch September 1, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants