Remove keyring requirement - replace with cookie/other token (gnome_keyring) #386

tzarebczan · 2017-07-26T04:12:49Z

The Issue

We've had some complaints and seensome startup issues because users didn't have gnome keyring installed. From what I understand, it's not on all Linux distros and some people choose to use it for various reasons. Is it possible to generate the auth token in a different way for Linux? Possibly some hash of the wallet pubkey and timestamp?

Steps to reproduce

Run bry-app without gnome keyring installed
hangs on authenticating screen
see daemon log below

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

LBRY Daemon version: 0.13.1
LBRY App version: 0.13.0
LBRY Installation ID:
Operating system: Kubuntu

Anything Else

017-07-01 01:00:28,047 INFO     lbrynet.lbrynet_daemon.Daemon:531: Starting to setup up file manager
2017-07-01 01:00:28,073 INFO     lbrynet.lbryfilemanager.EncryptedFileManager:126: Started 0 lbry files
2017-07-01 01:00:28,073 INFO     lbrynet.lbrynet_daemon.Daemon:542: Done setting up file manager
2017-07-01 01:00:28,075 INFO     lbrynet.lbrynet_daemon.Daemon:271: Starting balance: 0
2017-07-01 01:00:28,075 INFO     lbrynet.lbrynet_daemon.Daemon:248: Started lbrynet-daemon
2017-07-01 01:00:28,076 INFO     lbrynet.lbrynet_daemon.Daemon:249: 0 blobs in manager
2017-07-01 01:00:28,974 INFO     lbrynet.core.Wallet:809: Resolving lbry://one
** Message: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files
(node:5341) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: The name org.freedesktop.secrets was not provided by any .service files                                                                                              
(node:5341) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.                                                                        
** Message: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files                                                                                                          
(node:5341) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: The name org.freedesktop.secrets was not provided by any .service files

Screenshots

NeroBurner · 2017-07-26T08:11:30Z

I have exactly the same error

Platform: {
    "lbrynet_version": "0.13.1",
    "platform": "Linux-4.11.9-1-ARCH-x86_64-with-glibc2.3.4",
    "os_system": "Linux",
    "python_version": "2.7.12",
    "os_release": "4.11.9-1-ARCH",
    "lbryum_version": "2.8.4",
    "ip": "Could not determine IP",
    "lbryschema_version": "0.0.7",
    "processor": "",
    "build": "release"
}

Running Arch Linux (Antergos) with KDE Plasma 5.10.4-1

kauffj · 2017-07-26T11:27:57Z

We are using keytar: https://github.com/atom/node-keytar

Relevant code is at the end of this file: https://github.com/lbryio/lbry-app/blob/38fd451e72c60b0373a8e337bb1de1da37f7942a/app/main.js

It is unlikely we would prioritize this at the moment, but we'd be happy to bounty it.

NeroBurner · 2017-07-26T12:19:49Z

keytar uses libsecret, which is a frontend to gnome-keyring. KWallet does not support org.freedesktop.secrets

just installed the package gnome-keyring and everything workes fine

tzarebczan · 2017-08-02T19:23:23Z

Similar issues are discussed here: #422 and #423

filipnyquist · 2017-08-02T20:29:30Z

Some People cannot install the gnome-keyring as it Will put their current keyring out of place.

kauffj · 2017-09-18T16:08:51Z

This issue seems to be pretty common -- we really ought to be at least erroring on this in a clean enough way that users understand what's happening if we can't fix it outright.

tzarebczan · 2018-02-20T16:16:18Z

Opening this back up because the referenced file/commit (dbd147f) was changed to remove the dependency on gnome-keyring. This may have been during @IGassmann 's refactoring of the build process.

If you run the LBRY app on a KDE distro, the app fails to load anything on the front page as it's not able to get an authentication token.

Looks like keytar is supposed to support libsecret (atom/node-keytar#74) but it doesn't work as expected. I'm not sure what the next steps are - is it possible to just use libsecret instead of keytar, or they come hand in hand?

Krisseck · 2018-06-25T07:44:22Z

I can confirm that this is still an issue on a KDE-based distributions, the Explore page is blank and get this error on log:

┏ Electron -------------------

  ** Message: 10:40:35.238: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files

┗ ----------------------------
┏ Electron -------------------

  (node:16689) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 9): Error: The name org.freedesktop.secrets was not provided by any .service files

┗ ----------------------------

The version I am using is v0.22.0-rc.14

alyssaoc · 2018-08-21T17:17:29Z

@tzarebczan is this still happening

MattiP451 · 2019-06-23T18:22:27Z

I had to install gnome-keyring for LBRY 0.33.2 (and 0.33.1) to work. Without gnome-keyring it doesn't download or show any videos. I don't have to have or make an actual keyring for it to work but can just click cancel on the keyring window that pops up.

tzarebczan · 2019-06-23T19:08:05Z

We'll try to remove this requirement in the next few months. Thanks for reaching out!

Ventriduct · 2020-03-10T02:28:04Z

I'm having an issue where I can view content but when I try to sign in with my email, the page hangs. It doesn't get to the next screen titled "Check Your Email", nor does it send me the confirmation email. It works if I install the gnome-keyring package. It looks like that's not meant to be a dependency anymore and since I don't use gnome, I would greatly appreciate not needing it installed for LBRY.

Platform:

{
  "processor": "x86_64",
  "python_version": "3.7.6",
  "platform": "Linux-5.3.0-28-generic-x86_64-with-neon-18.04-bionic",
  "os_release": "5.3.0-28-generic",
  "os_system": "Linux",
  "lbrynet_version": "0.63.0",
  "version": "0.63.0",
  "build": "release",
  "distro": {
    "id": "neon",
    "version": "18.04",
    "version_parts": {
      "major": "18",
      "minor": "04",
      "build_number": ""
    },
    "like": "ubuntu debian",
    "codename": "bionic"
  },
  "desktop": "KDE"
}

Running KDE Neon User Edition 5.18 (Ubuntu 18.04 with KDE).

Thank you for the great app!
Ziah

tzarebczan · 2020-03-10T02:39:20Z

Sorry for the trouble. Try out the build at the top of lbry.com/faq/startup-troubleshooting - this has it removed completely. You'll need to check back there or the releases page for future updates until we can fix this.

Ventriduct · 2020-03-10T02:43:02Z

Sorry for the trouble. Try out the build at the top of lbry.com/faq/startup-troubleshooting - this has it removed completely. You'll need to check back there or the releases page for future updates until we can fix this.

Thanks for the quick reply. I found out through a related issue on keytar that it supports my password manager keepassxc, I got that working instead of gnome-keyring and I'm going to use that for now.

Thanks,
Ziah

Ventriduct · 2020-03-10T02:54:44Z

@tzarebczan FYI, I spoke too soon, it didn't actually work once I clicked the link in the confirmation email. I checked KeePassXC and no auth token was stored there. Nothing was added with the Free Desktop secret service.

The build on that troubleshooting page works just fine.

tzarebczan · 2020-04-01T17:31:26Z

We've removed it from the recent release (0.44), woohooo!!!

This was referenced Aug 2, 2017

Lbry app crashes at startup on Ubuntu 14.04-based system #421

Closed

gnome-keyring as a dependency on KDE systems #422

Closed

kauffj mentioned this issue Aug 14, 2017

LBRY fails to install on a custom ubuntu 14 installation #423

Closed

eriknelson mentioned this issue Sep 17, 2017

Seeing app hang during startup on "Fetching Content..." #572

Closed

kauffj added this to the September 25 milestone Sep 18, 2017

tzarebczan mentioned this issue Sep 18, 2017

Build fails on Fedora 26(4.12.12-300.fc26.x86_64) #583

Closed

lyoshenka closed this as completed in dbd147f Sep 21, 2017

byoms23 mentioned this issue Oct 20, 2017

Sorry, we had trouble logging you in. Foundry376/Mailspring#77

Closed

shiftkey mentioned this issue Dec 26, 2017

can't log in: The name org.freedesktop.secrets was not provided by any .service files shiftkey/desktop#7

Closed

tzarebczan reopened this Feb 20, 2018

lbry-bot added the needs: triage label Feb 20, 2018

tzarebczan mentioned this issue Feb 20, 2018

It still requires gnome-keyring even on KDE atom/node-keytar#74

Open

tzarebczan mentioned this issue Feb 28, 2018

Switch Back to node-keytar #1055

Closed

liamcardenas added type: improvement Existing (or partially existing) functionality needs to be changed area: devops needs: exploration Solution unclear, needs research and removed needs: triage area: devops labels Mar 2, 2018

alyssaoc removed this from the September 25 milestone Aug 21, 2018

alyssaoc added the priority: low Work should be done but can stay in the backlog for now label Aug 21, 2018

StephenWeatherford mentioned this issue Sep 11, 2018

Failed to add private Docker registry microsoft/vscode-docker#470

Closed

Chuxel mentioned this issue Sep 13, 2018

Feature Request: Support Kwallet in addition to libsecret based Linux keyrings microsoft/live-share#205

Closed

tzarebczan mentioned this issue Jun 26, 2019

LBRY terminates unexpectedly on Linux systems due to uncaught exception #2575

Closed

tzarebczan changed the title ~~Gnome Keyring required for auth_token generation?~~ Remove keyring requirement - replace with cookie/other token Jun 26, 2019

tzarebczan changed the title ~~Remove keyring requirement - replace with cookie/other token~~ Remove keyring requirement - replace with cookie/other token (gnome_keyring) Jun 26, 2019

tzarebczan added priority: medium Work needs to be done within 2-3 sprints and removed priority: low Work should be done but can stay in the backlog for now labels Jun 26, 2019

tzarebczan mentioned this issue Aug 28, 2019

[Linux][App] Content not loading #2804

Closed

tzarebczan mentioned this issue Feb 2, 2020

Cannot do most actions on OpenRC #3605

Closed

tzarebczan closed this as completed Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove keyring requirement - replace with cookie/other token (gnome_keyring) #386

Remove keyring requirement - replace with cookie/other token (gnome_keyring) #386

tzarebczan commented Jul 26, 2017 •

edited by hackrush01

Loading

NeroBurner commented Jul 26, 2017

kauffj commented Jul 26, 2017

NeroBurner commented Jul 26, 2017

tzarebczan commented Aug 2, 2017

filipnyquist commented Aug 2, 2017

kauffj commented Sep 18, 2017

tzarebczan commented Feb 20, 2018

Krisseck commented Jun 25, 2018 •

edited

Loading

alyssaoc commented Aug 21, 2018

MattiP451 commented Jun 23, 2019 •

edited

Loading

tzarebczan commented Jun 23, 2019

Ventriduct commented Mar 10, 2020 •

edited

Loading

tzarebczan commented Mar 10, 2020

Ventriduct commented Mar 10, 2020

Ventriduct commented Mar 10, 2020

tzarebczan commented Apr 1, 2020

Remove keyring requirement - replace with cookie/other token (gnome_keyring) #386

Remove keyring requirement - replace with cookie/other token (gnome_keyring) #386

Comments

tzarebczan commented Jul 26, 2017 • edited by hackrush01 Loading

The Issue

Steps to reproduce

Expected behaviour

Actual behaviour

System Configuration

Anything Else

Screenshots

NeroBurner commented Jul 26, 2017

kauffj commented Jul 26, 2017

NeroBurner commented Jul 26, 2017

tzarebczan commented Aug 2, 2017

filipnyquist commented Aug 2, 2017

kauffj commented Sep 18, 2017

tzarebczan commented Feb 20, 2018

Krisseck commented Jun 25, 2018 • edited Loading

alyssaoc commented Aug 21, 2018

MattiP451 commented Jun 23, 2019 • edited Loading

tzarebczan commented Jun 23, 2019

Ventriduct commented Mar 10, 2020 • edited Loading

tzarebczan commented Mar 10, 2020

Ventriduct commented Mar 10, 2020

Ventriduct commented Mar 10, 2020

tzarebczan commented Apr 1, 2020

tzarebczan commented Jul 26, 2017 •

edited by hackrush01

Loading

Krisseck commented Jun 25, 2018 •

edited

Loading

MattiP451 commented Jun 23, 2019 •

edited

Loading

Ventriduct commented Mar 10, 2020 •

edited

Loading