New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Keyring required for auth_token generation? #386

Open
tzarebczan opened this Issue Jul 26, 2017 · 9 comments

Comments

Projects
None yet
8 participants
@tzarebczan
Member

tzarebczan commented Jul 26, 2017

The Issue

We've had some complaints and seensome startup issues because users didn't have gnome keyring installed. From what I understand, it's not on all Linux distros and some people choose to use it for various reasons. Is it possible to generate the auth token in a different way for Linux? Possibly some hash of the wallet pubkey and timestamp?

Steps to reproduce

  1. Run bry-app without gnome keyring installed
  2. hangs on authenticating screen
  3. see daemon log below

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

  • LBRY Daemon version: 0.13.1
  • LBRY App version: 0.13.0
  • LBRY Installation ID:
  • Operating system: Kubuntu

Anything Else

017-07-01 01:00:28,047 INFO     lbrynet.lbrynet_daemon.Daemon:531: Starting to setup up file manager
2017-07-01 01:00:28,073 INFO     lbrynet.lbryfilemanager.EncryptedFileManager:126: Started 0 lbry files
2017-07-01 01:00:28,073 INFO     lbrynet.lbrynet_daemon.Daemon:542: Done setting up file manager
2017-07-01 01:00:28,075 INFO     lbrynet.lbrynet_daemon.Daemon:271: Starting balance: 0
2017-07-01 01:00:28,075 INFO     lbrynet.lbrynet_daemon.Daemon:248: Started lbrynet-daemon
2017-07-01 01:00:28,076 INFO     lbrynet.lbrynet_daemon.Daemon:249: 0 blobs in manager
2017-07-01 01:00:28,974 INFO     lbrynet.core.Wallet:809: Resolving lbry://one
** Message: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files
(node:5341) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: The name org.freedesktop.secrets was not provided by any .service files                                                                                              
(node:5341) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.                                                                        
** Message: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files                                                                                                          
(node:5341) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: The name org.freedesktop.secrets was not provided by any .service files

Screenshots

@NeroBurner

This comment has been minimized.

Show comment
Hide comment
@NeroBurner

NeroBurner Jul 26, 2017

I have exactly the same error

Platform: {
    "lbrynet_version": "0.13.1",
    "platform": "Linux-4.11.9-1-ARCH-x86_64-with-glibc2.3.4",
    "os_system": "Linux",
    "python_version": "2.7.12",
    "os_release": "4.11.9-1-ARCH",
    "lbryum_version": "2.8.4",
    "ip": "Could not determine IP",
    "lbryschema_version": "0.0.7",
    "processor": "",
    "build": "release"
}

Running Arch Linux (Antergos) with KDE Plasma 5.10.4-1

NeroBurner commented Jul 26, 2017

I have exactly the same error

Platform: {
    "lbrynet_version": "0.13.1",
    "platform": "Linux-4.11.9-1-ARCH-x86_64-with-glibc2.3.4",
    "os_system": "Linux",
    "python_version": "2.7.12",
    "os_release": "4.11.9-1-ARCH",
    "lbryum_version": "2.8.4",
    "ip": "Could not determine IP",
    "lbryschema_version": "0.0.7",
    "processor": "",
    "build": "release"
}

Running Arch Linux (Antergos) with KDE Plasma 5.10.4-1

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jul 26, 2017

Member

We are using keytar: https://github.com/atom/node-keytar

Relevant code is at the end of this file: https://github.com/lbryio/lbry-app/blob/38fd451e72c60b0373a8e337bb1de1da37f7942a/app/main.js

It is unlikely we would prioritize this at the moment, but we'd be happy to bounty it.

Member

kauffj commented Jul 26, 2017

We are using keytar: https://github.com/atom/node-keytar

Relevant code is at the end of this file: https://github.com/lbryio/lbry-app/blob/38fd451e72c60b0373a8e337bb1de1da37f7942a/app/main.js

It is unlikely we would prioritize this at the moment, but we'd be happy to bounty it.

@NeroBurner

This comment has been minimized.

Show comment
Hide comment
@NeroBurner

NeroBurner Jul 26, 2017

keytar uses libsecret, which is a frontend to gnome-keyring. KWallet does not support org.freedesktop.secrets

just installed the package gnome-keyring and everything workes fine

NeroBurner commented Jul 26, 2017

keytar uses libsecret, which is a frontend to gnome-keyring. KWallet does not support org.freedesktop.secrets

just installed the package gnome-keyring and everything workes fine

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 2, 2017

Member

Similar issues are discussed here: #422 and #423

Member

tzarebczan commented Aug 2, 2017

Similar issues are discussed here: #422 and #423

@filipnyquist

This comment has been minimized.

Show comment
Hide comment
@filipnyquist

filipnyquist Aug 2, 2017

Member

Some People cannot install the gnome-keyring as it Will put their current keyring out of place.

Member

filipnyquist commented Aug 2, 2017

Some People cannot install the gnome-keyring as it Will put their current keyring out of place.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 18, 2017

Member

This issue seems to be pretty common -- we really ought to be at least erroring on this in a clean enough way that users understand what's happening if we can't fix it outright.

Member

kauffj commented Sep 18, 2017

This issue seems to be pretty common -- we really ought to be at least erroring on this in a clean enough way that users understand what's happening if we can't fix it outright.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Feb 20, 2018

Member

Opening this back up because the referenced file/commit (dbd147f) was changed to remove the dependency on gnome-keyring. This may have been during @IGassmann 's refactoring of the build process.

If you run the LBRY app on a KDE distro, the app fails to load anything on the front page as it's not able to get an authentication token.

Looks like keytar is supposed to support libsecret (atom/node-keytar#74) but it doesn't work as expected. I'm not sure what the next steps are - is it possible to just use libsecret instead of keytar, or they come hand in hand?

Member

tzarebczan commented Feb 20, 2018

Opening this back up because the referenced file/commit (dbd147f) was changed to remove the dependency on gnome-keyring. This may have been during @IGassmann 's refactoring of the build process.

If you run the LBRY app on a KDE distro, the app fails to load anything on the front page as it's not able to get an authentication token.

Looks like keytar is supposed to support libsecret (atom/node-keytar#74) but it doesn't work as expected. I'm not sure what the next steps are - is it possible to just use libsecret instead of keytar, or they come hand in hand?

@Krisseck

This comment has been minimized.

Show comment
Hide comment
@Krisseck

Krisseck Jun 25, 2018

I can confirm that this is still an issue on a KDE-based distributions, the Explore page is blank and get this error on log:

┏ Electron -------------------

  ** Message: 10:40:35.238: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files

┗ ----------------------------
┏ Electron -------------------

  (node:16689) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 9): Error: The name org.freedesktop.secrets was not provided by any .service files

┗ ----------------------------

The version I am using is v0.22.0-rc.14

Krisseck commented Jun 25, 2018

I can confirm that this is still an issue on a KDE-based distributions, the Explore page is blank and get this error on log:

┏ Electron -------------------

  ** Message: 10:40:35.238: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files

┗ ----------------------------
┏ Electron -------------------

  (node:16689) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 9): Error: The name org.freedesktop.secrets was not provided by any .service files

┗ ----------------------------

The version I am using is v0.22.0-rc.14

@alyssaoc

This comment has been minimized.

Show comment
Hide comment
@alyssaoc

alyssaoc Aug 21, 2018

Member

@tzarebczan is this still happening

Member

alyssaoc commented Aug 21, 2018

@tzarebczan is this still happening

@alyssaoc alyssaoc removed this from the September 25 milestone Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment