Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor redesign (css) #647

Merged
merged 52 commits into from
Oct 10, 2017
Merged

Minor redesign (css) #647

merged 52 commits into from
Oct 10, 2017

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented Oct 2, 2017

A user interface is like a joke. If you have to explain it, it’s not that good.

Changes

A bunch of minor CSS fixes and additional changes.

Fixes

Additional changes

  • Header redesign (css).
  • Search bar UX / UI enhancement (css).
  • Checkbox redesign (css).
  • Radio button redesign (css).
  • Minor update for tile component (css)
  • Minor update for report button. (icon)
  • Minor update for support button. (css)
  • Minor update for edit button. (css)
  • Minor update for file actions. (css)
  • File input (css).
  • Cleanup Wallet page (css).

Todo

  • Update changelog.

@btzr-io
Copy link
Collaborator Author

btzr-io commented Oct 2, 2017

@kauffj I re-open this because -> #639 would take a while to get merged,
You can merge this right now 🙃

@btzr-io btzr-io requested a review from kauffj October 2, 2017 15:33
@btzr-io btzr-io added css type: improvement Existing (or partially existing) functionality needs to be changed area: ux labels Oct 2, 2017
@btzr-io btzr-io added this to the Redesign milestone Oct 2, 2017
@btzr-io
Copy link
Collaborator Author

btzr-io commented Oct 5, 2017

More notes

  • Currently the report button seems hard to noticed, and looks like don't belong there...

@kauffj
Copy link
Member

kauffj commented Oct 5, 2017

@btzr-io I am fine with dropping the URI from FileTile. It would actually probably be pretty easy to add in FileActions to those cards... not sure if that's actually a good idea or not.

@btzr-io
Copy link
Collaborator Author

btzr-io commented Oct 8, 2017

don't support your own claims :( dd8ab64

@kauffj I'm still confused about the support behavior:
Do we actually need to support our own claims ?

Note

There are too many buttons in fileActions,
I guess is time to bring back the menu component or do something smart 😛

add more focus for support button

minor fixes css
@btzr-io
Copy link
Collaborator Author

btzr-io commented Oct 9, 2017

Duplicated content

duplicated

@btzr-io
Copy link
Collaborator Author

btzr-io commented Oct 9, 2017

cleanup

@kauffj
Copy link
Member

kauffj commented Oct 9, 2017

@btzr-io I think dd8ab64 could cause user confusion ("why is the support button missing on my content?")

@kauffj
Copy link
Member

kauffj commented Oct 9, 2017

And yes... let's fix FileActions!

@kauffj
Copy link
Member

kauffj commented Oct 10, 2017

I merged this, since it's a clear step up from the current app. I opened two issues regarding outstanding changes that I think are still worth making:

#656
#657

@kauffj kauffj merged commit 2039ab7 into master Oct 10, 2017
@btzr-io btzr-io mentioned this pull request Oct 11, 2017
12 tasks
@btzr-io btzr-io deleted the css_patch branch October 11, 2017 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux css type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants