Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw error when trying to play empty collections. #7571

Merged
merged 3 commits into from
May 6, 2022
Merged

Do not throw error when trying to play empty collections. #7571

merged 3 commits into from
May 6, 2022

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented Apr 28, 2022 •
edited
Loading

Fixes

Issue Number: #7140

What is the current behavior?

When playing empty lists there is an error showing up.

What is the new behavior?

  • No error is thrown when trying to play an empty list.
  • The play/shuffle button gets disabled for an empty list.
  • The shuffle button doesn't appear for empty lists.

image

image

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

@Ruk33 Ruk33 requested a review from jessopb April 28, 2022 13:13
jessopb
jessopb reviewed May 1, 2022
View reviewed changes
Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruk33 mentioned we should disable the button too. We should probably avoid any attempt to "play" the collection.

@Ruk33 Ruk33 requested a review from jessopb May 4, 2022 14:27
@jessopb jessopb merged commit 6108860 into master May 6, 2022
@jessopb jessopb deleted the 7140-minor-cleanup-error-when-trying-to-play-empty-watch-later branch May 6, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessopb jessopb Awaiting requested review from jessopb

Assignees

@jessopb jessopb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruk33 @jessopb