Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle thumbnail field in publish/edit upload/collection. #7574

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented Apr 29, 2022

Fixes

Issue Number: #7561

What is the current behavior?

The thumbnail field for uploads and collections is not
handling the thumbnails correctly nor is resetting its
state when entering one of these views.

What is the new behavior?

When the user enters to new upload, edit upload, new
collection or edit collection, the thumbnail field
will reset to its initial state and the thumbnail
will be displayed (if the claim has one)

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

@Ruk33 Ruk33 requested a review from jessopb April 29, 2022 19:29
@lbry-bot lbry-bot assigned jessopb and unassigned jessopb Apr 29, 2022
@jessopb jessopb merged commit 02e4b65 into master May 2, 2022
@jessopb jessopb deleted the 7561-upload-thumbnail-in-playlist-gets-displayed-in-uploads-page branch May 2, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants