Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap comment servers without going to settings page #7365 #7670

Conversation

ByronEricPerez
Copy link
Contributor

Fixes

Issue Number: #7365

What is the current behavior?

What is the new behavior?

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

@jessopb
Copy link
Member

jessopb commented Aug 11, 2022

Good progress. Besides fixing styling, this should be at the top next to the refresh button.

The refresh button reloads all comments. The server selector changes the server for all comments.

Below, the comment field adds one comment.

Also, don't forget to make the selector only show up when the number of servers is > 1.

@kodxana
Copy link
Contributor

kodxana commented Aug 15, 2022

@ByronEricPerez What do you think if we could have option in app to integrate using multiple comments servers into single feed.
Aka at the same time user could see Odysee comments and also other comments server, or user can decide to limit to selected comments servers or just use single one.

@ByronEricPerez
Copy link
Contributor Author

Hi @jessopb how are you, I have already corrected the location, in addition to the fact that it only shows if there are 2 or more commentServer, I just need to add that it shows the comments. And finally some css.

Hi @kodxana , I think the idea is good, it would also be more practical to have the option of being able to show them all in one.

image
image

@ByronEricPerez
Copy link
Contributor Author

ByronEricPerez commented Aug 26, 2022

Hi @jessopb , I'm having trouble seeing the comments on all the videos.
The btn moved it to the correct component, it already synchronizes, I need to align it a little more. What do you think?

image

Although I comment I get an error asking me to restart, but I have that comment in my history.
I also don't see comments on any video. This error started appearing yesterday.

@ByronEricPerez
Copy link
Contributor Author

Fixed why it didn't show comments , the error was in index.js

image

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
I think we keep refresh button all the way to the right.
And the alignment issue you mentioned.

ui/scss/component/_card.scss Outdated Show resolved Hide resolved
@jessopb
Copy link
Member

jessopb commented Aug 30, 2022

Put the refresh button last, and it's a bit too wide, I think.

@jessopb
Copy link
Member

jessopb commented Sep 5, 2022

@kodxana would you like to test this branch?

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

ui/scss/component/_card.scss Outdated Show resolved Hide resolved
ui/scss/component/_card.scss Outdated Show resolved Hide resolved
@ByronEricPerez ByronEricPerez marked this pull request as ready for review September 13, 2022 14:40
ui/component/commentsList/view.jsx Outdated Show resolved Hide resolved
ui/scss/component/_card.scss Outdated Show resolved Hide resolved
Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out and it looks pretty good. Two more things.

  • Rebase it on master
  • call refresh when it switches

work in progress

added input to select custom and default server when creating comment

the problem of synchronizing the two commentServer of the application was solved

btn moved to the correct component and syncs correctly

Fixed why it didn't show comments

Aligned input

size and location of the refresh btn changed, and added maximum and minimum width for the comment server

margin removed

change using overflow

refresh
@ByronEricPerez ByronEricPerez force-pushed the Swap_comment_servers_without_going_to_settings_page_#7365 branch from 1038181 to d7c6b50 Compare October 24, 2022 14:32
@jessopb jessopb merged commit 7ad66b9 into lbryio:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants