-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap comment servers without going to settings page #7365 #7670
Swap comment servers without going to settings page #7365 #7670
Conversation
Good progress. Besides fixing styling, this should be at the top next to the refresh button. The refresh button reloads all comments. The server selector changes the server for all comments. Below, the comment field adds one comment. Also, don't forget to make the selector only show up when the number of servers is > 1. |
@ByronEricPerez What do you think if we could have option in app to integrate using multiple comments servers into single feed. |
Hi @jessopb how are you, I have already corrected the location, in addition to the fact that it only shows if there are 2 or more commentServer, I just need to add that it shows the comments. And finally some css. Hi @kodxana , I think the idea is good, it would also be more practical to have the option of being able to show them all in one. |
Hi @jessopb , I'm having trouble seeing the comments on all the videos. Although I comment I get an error asking me to restart, but I have that comment in my history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress!
I think we keep refresh button all the way to the right.
And the alignment issue you mentioned.
Put the refresh button last, and it's a bit too wide, I think. |
@kodxana would you like to test this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it out and it looks pretty good. Two more things.
- Rebase it on master
- call refresh when it switches
work in progress added input to select custom and default server when creating comment the problem of synchronizing the two commentServer of the application was solved btn moved to the correct component and syncs correctly Fixed why it didn't show comments Aligned input size and location of the refresh btn changed, and added maximum and minimum width for the comment server margin removed change using overflow refresh
1038181
to
d7c6b50
Compare
Fixes
Issue Number: #7365
What is the current behavior?
What is the new behavior?
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":