Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize values for CSV. #7697

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented Oct 10, 2022

Fixes

Issue Number: #7692

What is the current behavior?

When exporting to CSV, no sanitization is being performed, thus,
the export may be incorrect if any of the values use a comma
or ".

What is the new behavior?

All values are enclosed in " and extra " are escaped.

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question..

ui/util/parse-data.js Outdated Show resolved Hide resolved
@jessopb jessopb merged commit a4c34d8 into master Oct 17, 2022
@jessopb jessopb deleted the 7692-transaction-export-creates-invalid-csv-file branch October 17, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants