New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not kill an existing daemon, but check if one exists #973

Merged
merged 7 commits into from Jan 31, 2018

Conversation

Projects
None yet
3 participants
@IGassmann
Contributor

IGassmann commented Jan 29, 2018

This removes the functionality of killing an existing daemon and instead checks for an existing one and connect to it.

This will also close #298.

@IGassmann IGassmann changed the title from This removes the fonctionnality of killing an existing daemon and instead checks for an existing one and connect to it. to Do not kill an existing daemon, but check if one exists Jan 29, 2018

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Jan 29, 2018

Contributor

This will wait for electron-userland/electron-builder@ad199c4 to be released.

Contributor

IGassmann commented Jan 29, 2018

This will wait for electron-userland/electron-builder@ad199c4 to be released.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jan 29, 2018

Member

@IGassmann are you sure daemon killing actually happens? Is it default behavior? I'm relatively confident that if I launch lbrynet-daemon from the command line and then launch the app, that it will connect to that running instance already.

Member

kauffj commented Jan 29, 2018

@IGassmann are you sure daemon killing actually happens? Is it default behavior? I'm relatively confident that if I launch lbrynet-daemon from the command line and then launch the app, that it will connect to that running instance already.

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Jan 29, 2018

Contributor

@kauffj that was the behavior before the refactoring. However, during the refactoring I made the app to kill any existing daemon before starting in order to fix #298. With the coming electron-builder release it won't be necessary anymore.

Contributor

IGassmann commented Jan 29, 2018

@kauffj that was the behavior before the refactoring. However, during the refactoring I made the app to kill any existing daemon before starting in order to fix #298. With the coming electron-builder release it won't be necessary anymore.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jan 29, 2018

Member

👍

Member

kauffj commented Jan 29, 2018

👍

Igor Gassmann added some commits Jan 29, 2018

Igor Gassmann
Igor Gassmann

@IGassmann IGassmann merged commit 8b9144c into master Jan 31, 2018

2 checks passed

Linux (LBRY App) TeamCity build finished
Details
OSX (LBRY App) TeamCity build finished
Details

@IGassmann IGassmann deleted the issue/298 branch Feb 27, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Mar 11, 2018

Member

@IGassmann does electron builder need to be updated again after the latest commit in: electron-userland/electron-builder#2516

Member

tzarebczan commented Mar 11, 2018

@IGassmann does electron builder need to be updated again after the latest commit in: electron-userland/electron-builder#2516

@IGassmann

This comment has been minimized.

Show comment
Hide comment
@IGassmann

IGassmann Mar 12, 2018

Contributor

@tzarebczan Yes, I'm waiting for 20.5.0 to be released for upgrading. It'll also solve this: electron-userland/electron-builder#2670.

Thanks for notifying me.

Contributor

IGassmann commented Mar 12, 2018

@tzarebczan Yes, I'm waiting for 20.5.0 to be released for upgrading. It'll also solve this: electron-userland/electron-builder#2670.

Thanks for notifying me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment