fix wallet instance checks in the jsonrpc_status daemon method #1267
Conversation
| wallet_is_encrypted = has_wallet_with_network and self.session.wallet.wallet and \ | ||
| self.session.wallet.wallet.use_encryption | ||
| headers_progress_percent = self.session.wallet.get_headers_progress_percent() if has_wallet else 0 | ||
| headers_progress_percent = 0 if not has_wallet else self.session.wallet.get_headers_progress_percent() |
There was a problem hiding this comment.
In Python you can have a function followed by an if ... and the function won't be called unless the condition is true. Here is an example:
>>> def alternative():
... print('alternative called!')
...
>>> alternative() if False else 'nope!'
'nope!'
>>> It's difficult to tell what is actually changed above, logically. Can you undo all of the swapped conditionals and just leave the line that fixed the original problem.
There was a problem hiding this comment.
@eukreign There's a discussion thread about these changes. I will send you a link.
There was a problem hiding this comment.
I read the chat. Maybe the confusion is from the comment about reading from left to right? In which case that's referring to attribute access and not the order in which inline if statements are evaluated. See my code example above which shows that alternative() does not get called.
|
No longer required. |
No description provided.