wallet servers requesting a daily fee will automatically get paid by client #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
force-pushed
the
pay_wallet_servers
branch
4 times, most recently
from
4be45c6
to
32614d2
Compare
shyba
force-pushed
the
pay_wallet_servers
branch
3 times, most recently
from
4a51d05
to
7da1f42
Compare
shyba
force-pushed
the
pay_wallet_servers
branch
from
7da1f42
to
7d47d5c
Compare
shyba
force-pushed
the
pay_wallet_servers
branch
from
7d47d5c
to
ee4b14b
Compare
eukreign
requested changes
Feb 9, 2020
lbry/wallet/manager.py
Outdated
| @@ -79,11 +81,14 @@ def accounts(self): | |||
| await asyncio.gather(*( | |||
| l.start() for l in self.ledgers.values() | |||
| )) | |||
| self.usage_payment_service = WalletServerPayer(self.ledger, self.default_wallet) | |||
There was a problem hiding this comment.
Can this be instantiated in __init__ then you won't need to add Optional to the type?
| LEDGER = lbry.wallet | ||
|
|
||
| def setUp(self) -> None: | ||
| WalletServerPayer.PAYMENT_PERIOD = 1 |
There was a problem hiding this comment.
Can this just be a configurable thing in the WalletServerPayer (eg. an argument to WalletServerPayer.init which then uses the PAYMENT_PERIOD constant as a default)?
|
|
||
|
|
||
| class TestUsagePayment(CommandTestCase): | ||
| LEDGER = lbry.wallet |
lbry/wallet/usage_payment.py
Outdated
| tx = await Transaction.create([], | ||
| [Output.pay_pubkey_hash(amount, self.ledger.address_to_hash160(address))], | ||
| self.wallet.get_accounts_or_all(None), | ||
| self.wallet.get_account_or_default(None)) |
There was a problem hiding this comment.
formatting is strange, needs indentation fix
lbry/wallet/usage_payment.py
Outdated
| self.wallet.get_account_or_default(None)) | ||
|
|
||
| await self.ledger.broadcast(tx) | ||
| # await self.analytics_manager.send_credits_sent() fixme: handle that |
lbry/wallet/usage_payment.py
Outdated
| if not self.ledger.is_valid_address(address): | ||
| raise Exception(f"Invalid address: {address}") | ||
| if self.wallet.is_locked: | ||
| raise Exception("Cannot spend funds with locked wallet") |
There was a problem hiding this comment.
I think this will kill the pay service, even after the wallet is unlocked no payment will be sent. Perhaps just print a message and continue running?
shyba
force-pushed
the
pay_wallet_servers
branch
3 times, most recently
from
b9e0c48
to
b261df0
Compare
eukreign
approved these changes
Feb 17, 2020
eukreign
force-pushed
the
pay_wallet_servers
branch
from
b261df0
to
5695b18
Compare
eukreign
changed the title
eukreign
changed the title
eukreign
added
area: hub
type: new feature
shyba
force-pushed
the
pay_wallet_servers
branch
from
dbd72ec
to
9e040d2
Compare
shyba
force-pushed
the
pay_wallet_servers
branch
from
9e040d2
to
f0e1db3
Compare
lyoshenka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #2683
Changes in this PR:
New SDK component:
WALLET_SERVER_PAYMENTS_COMPONENTNew configuration key:
max_wallet_server_fee(defaults to 1.0)Wallet server config options:
PAYMENT_ADDRESSandDAILY_FEEDuring SDK startup, if its not set to skip, the component for payments starts by reading
max_wallet_server_feethen sleeping for 24 hours.On the wallet server, operators can set the configurations for a daily fee and the address for it, however there isn't any enforcement yet.
After 24 hours, the component wakes up, pays to the current "master" server and goes back to sleep. This only happens if there is a valid address and fee set on the main server and that fee is below the configured threshold.
It also sends analytics when after it pays