Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't validate and repair files that aren't videos; add maximum video bit rate setting #2793

Merged
merged 5 commits into from
Mar 4, 2020
Merged

don't validate and repair files that aren't videos; add maximum video bit rate setting #2793

merged 5 commits into from
Mar 4, 2020

Conversation

BrannonKing
Copy link
Member

Also fix ogg vs ogv mismatch.

@lyoshenka
Copy link
Member

lyoshenka commented Feb 14, 2020 •
edited
Loading

@BrannonKing is this ready for review? if yes, please request review from @lbryio/protocools

eukreign
eukreign requested changes Feb 17, 2020
View reviewed changes
lbry/extras/daemon/daemon.py Outdated Show resolved Hide resolved
lbry/schema/mime_types.py Outdated Show resolved Hide resolved
@lbry-bot lbry-bot assigned BrannonKing and unassigned BrannonKing Feb 19, 2020
@BrannonKing BrannonKing changed the title ignore files that aren't video ignore files that aren't video, add max bps check Mar 4, 2020
eukreign
eukreign requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@eukreign eukreign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see two minor things below and then please rebase this and we can merge

lbry/testcase.py Outdated Show resolved Hide resolved
lbry/extras/daemon/daemon.py Outdated Show resolved Hide resolved
@eukreign eukreign changed the title ignore files that aren't video, add max bps check ignore validating and repairing files that aren't videos; add maximum video bit rate setting Mar 4, 2020
@lbry-bot lbry-bot assigned BrannonKing and unassigned BrannonKing Mar 4, 2020
@BrannonKing BrannonKing changed the title ignore validating and repairing files that aren't videos; add maximum video bit rate setting don't validate and repair files that aren't videos; add maximum video bit rate setting Mar 4, 2020
@eukreign eukreign added area: blobs/files type: improvement Existing (or partially existing) functionality needs to be changed labels Mar 4, 2020
@eukreign eukreign merged commit c4905d0 into master Mar 4, 2020
@eukreign eukreign deleted the dont_validate_non_video branch March 4, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eukreign eukreign eukreign approved these changes

Assignees

@BrannonKing BrannonKing

Labels
area: files type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrannonKing @lyoshenka @eukreign @jackrobison