revert LD_LIBRARY_PATH before calling ffmpeg #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eukreign
requested changes
Mar 5, 2020
eukreign
added
area: files
type: bug
BrannonKing
force-pushed
the
debug_find_ffmpeg
branch
from
12f5ad7
to
4d684f7
Compare
eukreign
requested changes
Mar 6, 2020
BrannonKing
force-pushed
the
debug_find_ffmpeg
branch
from
4d684f7
to
252344f
Compare
eukreign
approved these changes
Mar 6, 2020
BrannonKing
force-pushed
the
debug_find_ffmpeg
branch
from
252344f
to
44ce4c9
Compare
jackrobison
force-pushed
the
debug_find_ffmpeg
branch
from
44ce4c9
to
212c8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyInstaller modifies the LD_LIBRARY_PATH variable. This affects the execution of files external to the package. It was affecting the execution of ffmpeg but is handled here as suggested in the documentation at https://pyinstaller.readthedocs.io/en/stable/runtime-information.html#ld-library-path-libpath-considerations
Fixes #2838