Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wallet_syncing to status, which is set to true when processing transaction updates #2881

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

shyba
Copy link
Member

@shyba shyba commented Mar 24, 2020

No description provided.

@shyba shyba added area: wallet type: new feature New functionality that does not exist yet area: api labels Mar 24, 2020
@shyba shyba requested a review from eukreign March 24, 2020 03:56
@tzarebczan
Copy link
Contributor

This is good for a first start for desktop users (they'll need to re-sync, so I'd really like to get this in) but it should be returned in wallet_status and not status.

For lbry.tv, it may not be worth it if we are moving away from sync all together.

@jackrobison jackrobison changed the title add wallet_syncing to status, which is set to true when processing transaction updates add wallet_syncing to status, which is set to true when processing transaction updates Mar 26, 2020
@jackrobison jackrobison merged commit 15eb5d4 into master Mar 26, 2020
@jackrobison jackrobison deleted the wallet_sync_status branch March 26, 2020 19:28
@jackrobison jackrobison changed the title add wallet_syncing to status, which is set to true when processing transaction updates added wallet_syncing to status, which is set to true when processing transaction updates Mar 26, 2020
@kauffj
Copy link
Member

kauffj commented Mar 26, 2020

lbryio/lbry-desktop#3903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api area: wallet type: new feature New functionality that does not exist yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants