add allowed_origin to config, by default no longer allow any requests which pass Origin in header
#2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackrobison
added
type: improvement
eukreign
requested changes
Jun 1, 2020
|
-raise 403 error if a request doesn't have a matching origin
eukreign
changed the title
allowed_origin to configallowed_origin to config, no longer allow any requests which pass Origin in header by default
eukreign
approved these changes
Jun 3, 2020
eukreign
changed the title
allowed_origin to config, no longer allow any requests which pass Origin in header by defaultallowed_origin to config, by default no longer allow any requests which pass Origin in header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backwards-incompatible: This release requires that no Origin value is passed in HTTP API requests. Electron based apps accessing the SDK will need to make sure that for
POSTrequests that they remove theOriginfrom the header, see: electron/electron#7931 . When you want to use the API from web browser the SDK needs to haveallowed_originconfiguration value set to the host from which you want to access the API.