Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esw): resume inferBuildOption Observable #28

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Conversation

lbwa
Copy link
Owner

@lbwa lbwa commented Jan 8, 2022

rxjs@7.5.1 would never complete the following observable:

const inferenceMeta$ = combineLatest([
pkgJson$,
inferredOutPaths$,
moduleIdFields$,
alternativeFormats$
]).pipe(

therefore, the following toArray would never be completed,

and it occur run$ observable never be completed.

return firstValueFrom(run$)

@lbwa lbwa added the type: bug Something isn't working label Jan 8, 2022
@lbwa lbwa merged commit 76172ef into main Jan 8, 2022
@lbwa lbwa deleted the fix_empty_execution branch January 8, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant