Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix package name in debian control file (#177) #188

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

vbalyasnyy
Copy link
Contributor

@vbalyasnyy vbalyasnyy commented Dec 8, 2019


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@coveralls
Copy link

coveralls commented Dec 8, 2019

Coverage Status

Coverage increased (+2.01%) to 68.537% when pulling 9310301 on vbalyasnyy:develop into dabe1cb on lc-soft:develop.

@lc-soft lc-soft self-assigned this Dec 9, 2019
Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is not resolved.

debian/lcui-dev.install Outdated Show resolved Hide resolved
@vbalyasnyy vbalyasnyy force-pushed the develop branch 2 times, most recently from f4fe6b6 to 50bfe07 Compare December 9, 2019 21:47
@vbalyasnyy vbalyasnyy changed the title build: fix *.deb package install script (#177) build: fix package name in debian control file (#177) Dec 9, 2019
Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request rename package and related config files.

debian/control Outdated
@@ -15,7 +15,7 @@ Multi-Arch: same
Depends: lcui (= ${binary:Version}), ${misc:Depends}
Description: A small C library for building user interfaces.

Package: lcui
Package: lcui1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this document: https://www.netfort.gr.jp/~dancer/column/libpkg-guide/libpkg-guide.html#naminglibpkg

We should rename the package to liblcui1

Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lcui-dev* -> liblcui1-dev*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants