Add lcm_eventlog_read_prev_event #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to lcm_eventlog_read_next_event, events can now be iterated through backwards As part of this, common functionality between lcm_eventlog_read_next_event and the new lcm_eventlog_read_prev_event was pulled out into a local helper function read_event_helper
In read_event_helper (which was previously code in lcm_eventlog_read_next_event) le->data was free'd before it was calloc'd in error handling
|
Sorry for ignoring this for so long. The LCM log format is not designed for reading in reverse, and so this is not a feature I'd like to build into the API. Since the file pointer is exposed, my suggestion if you still want this functionality would be to add it to your own utility library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an eventlog function lcm_eventlog_read_prev_event for iterating backwards through an lcm_eventlog_t.
As part of this I pulled out common code between read_next and read_prev into a helper function.
I also fixed a bug in freeing memory during error checking that was previously in read_next_event, and is now in the helper function.