Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup by identifier #30

Merged
merged 6 commits into from
Aug 28, 2018
Merged

Lookup by identifier #30

merged 6 commits into from
Aug 28, 2018

Conversation

cledvina
Copy link
Collaborator

This may need more work (I haven't checked all lookups.) However, looking up names and subjects works nicely. So here's the concept.

  1. The IDs display in the suggestions for all lookups that use the processSuggestions or processATOM functions.
  2. When clicking on the suggestion only the value populates the form (no ID in parenthesis.) This is unlike the lookup works stuff where the IDs display and are also included in the form value-- I don't know if this is a bug or the catalogers want it in there.
  3. The lookup detects an ID search if the query starts with a 'n' for names, 's' for subjects and the second character is either a letter or number or if the third character is a number. If so, then it performs an atom search (this does not work with genre lookups because of a CORS issue.)

So, that's basically it.

Enjoy,
--Charles

Copy link
Contributor

@kirkhess kirkhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cledvina cledvina merged commit 88f7d40 into development Aug 28, 2018
@cledvina cledvina deleted the lookup-by-identifier branch August 28, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants