Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the token interface #117

Closed
5 tasks done
lcobucci opened this issue Sep 30, 2016 · 0 comments
Closed
5 tasks done

Improve the token interface #117

lcobucci opened this issue Sep 30, 2016 · 0 comments
Labels
Improvement
Milestone
4.0.0-alpha1

Comments

@lcobucci
Copy link
Owner

lcobucci commented Sep 30, 2016 •
edited
Loading

In order to provide a better encapsulation for the token we should provide methods to:

  • check if token can already be used (nbf - not before - claim is <= now)
  • check if token was issued before a given time (iat claim - issued at - claim is <= now)
  • check if token was issued by one of a list of issuers (iss - issuer - claim)
  • check if token can be used by a client (aud - audience - claim)
  • check if token is related to a certain subject (sub - subject - claim)
@lcobucci lcobucci mentioned this issue Nov 7, 2016
Merged
lcobucci added a commit that referenced this issue Nov 16, 2016
@lcobucci
Reorganize Token structure
95a207a 
Yes this is a big change... brace yourself!
The ideia here is to make things more extensible and decoupled.

So what I did was:

- Extract interfaces for the important stuff to isolate the namespaces
- Create the DataSet class (definitely not best name)  to remove duplication
 on headers and claims manipulation
- Make (almost) everything final
- Group token related stuff under a namespace
- Create methods to encapsulate token verifications

Fixes: #117
@lcobucci lcobucci added this to the 4.0.0 milestone Nov 24, 2016
lcobucci added a commit that referenced this issue Jan 7, 2017
@lcobucci
Reorganize Token structure
2354850 
Yes this is a big change... brace yourself!
The ideia here is to make things more extensible and decoupled.

So what I did was:

- Extract interfaces for the important stuff to isolate the namespaces
- Create the DataSet class (definitely not best name)  to remove duplication
 on headers and claims manipulation
- Make (almost) everything final
- Group token related stuff under a namespace
- Create methods to encapsulate token verifications

Fixes: #117
lcobucci added a commit that referenced this issue Jan 7, 2017
@lcobucci
Reorganize Token structure
8c6fff1 
Yes this is a big change... brace yourself!
The ideia here is to make things more extensible and decoupled.

So what I did was:

- Extract interfaces for the important stuff to isolate the namespaces
- Create the DataSet class (definitely not best name)  to remove duplication
 on headers and claims manipulation
- Make (almost) everything final
- Group token related stuff under a namespace
- Create methods to encapsulate token verifications

Fixes: #117
Horikawaer pushed a commit to Horikawaer/jwt that referenced this issue Nov 3, 2022
@lcobucci
Reorganize Token structure
d89b7cd 
Yes this is a big change... brace yourself!
The ideia here is to make things more extensible and decoupled.

So what I did was:

- Extract interfaces for the important stuff to isolate the namespaces
- Create the DataSet class (definitely not best name)  to remove duplication
 on headers and claims manipulation
- Make (almost) everything final
- Group token related stuff under a namespace
- Create methods to encapsulate token verifications

Fixes: lcobucci/jwt#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.0.0-alpha1
Development

No branches or pull requests
1 participant
@lcobucci