Update ldap filter #521
Update ldap filter #521
Conversation
|
It looks like you still need to enable the travis builds on /ldapjs/node-ldapjs/ |
|
You should also setup appveyor for testing on windows |
I am waiting on a reply for an application to GitHub Actions so that I can setup CI with GitHub CI. Currently just running tests manually where I need to and accepting blindly where it looks good. There's a long road to a new release... |
There was a problem hiding this comment.
Why remove the tests? Shouldn't they instead be updated to correctly test the desired behavior? How about adding a test that explicitly tests the new functionality?
In the future, when updating someone's abandoned PR, please start your branches off of their branches (where feasible). This will include their original work and give them some credit for their attempted efforts.
The tests that I removed tested special characters in attribute names which is no longer supported in ldap-filter.
There are already tests that cover special characters in the attribute values. I left those alone and made sure those are still passing. |
|
Please include a minimal reproducible example |
ldap-filter v0.3.0 has a few breaking changes.
Some of the tests are breaking because they don't allow special characters in an attribute name.
fixes #402