Minor fixes #2226
Merged
Minor fixes #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ((AbstractJobStructure) job).getStructure().rotate(rotateTimes, world, position, isMirrored ? Mirror.FRONT_BACK : Mirror.NONE); | ||
| ((AbstractJobStructure) job).getStructure().setPosition(position); | ||
| } | ||
| catch(final NullPointerException ex) |
There was a problem hiding this comment.
|
SonarQube analysis reported 89 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
marchermans
approved these changes
Feb 14, 2018
Raycoms
added a commit
that referenced
this pull request
Feb 14, 2018
Fixes constructiontape being placed on workLoad Fixes issues with deleted structures Protects buildings from being detected as trees Reduces particle effects Reports block position if tool is not good enough.
Raycoms
added a commit
that referenced
this pull request
Feb 14, 2018
* Open GUI on server-side, not client-side (#2195) Changes proposed in this pull request: Get rid of evil comment. Change gui open from client-side to server-side. (Fixes #2194) * fix the smelter (#2189) Rewrite of Smelter and cook to gain more stability. Also fixes the hitboxes of the new construction-tape. * fixe herders spawn egg problem and cycling recipes (#2202) * Feature/better builder (#2209) Fixes message concurrency issues Fixes timberframe issues Fixes dumping issues * 1.11/last-changes: Auto stash before cherrypick of "fix the smelter (#2189)" * fix compile issues * Minor fixes (#2226) Fixes constructiontape being placed on workLoad Fixes issues with deleted structures Protects buildings from being detected as trees Reduces particle effects Reports block position if tool is not good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2223
Closes #2224
Closes #2219
Closes #2219
Closes #2213
Closes #2217
Changes proposed in this pull request:
Review please