Feature/compost block #2605
Merged
Feature/compost block #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not working at the moment. Crashes on launch
Added the model for the compost block.
Fixed some problems with the model, and added the capability of changing its state with right click.
The basic functionality works, but it sometimes "forgets" that it has the items it had. Have to work on that. For now it drops 1 bone from each 64 mats (rotten flesh counts as double) in like 1-2 mins (will increase time and drop)
Little fixes here and there. Still "eating" items
Functionality of the barrel block working. Pending of testing and configuring (time needed, drop amounts, etc).
Added a model for the barrel while its working (the same barrel but with a lid on it)
Added particles to the finish state and directions for the block. Pending of final details.
Fixed a problem where the barrel orientation will change randomly in servers. Test pending
Looks like the client isn´t getting the state of the barrel quite right. It gets the orientation right, though
Trying to get the barrel updated every time the player uses it. For now you have to force the update modifying blocks arround it.
The barrel updates fine in singleplayer and works as intended. Minor adjustments pending.
Added the signature for the methods to be used as interface with the AI
Logic now gets executed on server and the barrel gets synced in server and client. Added a configuration to set, unset items that can be processed by the barrel
The BarrelBlock is done and working (pending from further testing), and the compost item was included in the items and its funcionallity done, pending from graphics.
They are both working and pending from testing.
Raycoms
reviewed
Jul 8, 2018
| @Override | ||
| public IBlockState getStateForPlacement( | ||
| @NotNull final World world, @NotNull final BlockPos pos, @NotNull final EnumFacing facing, final float hitX, final float hitY, | ||
| final float hitZ, final int meta, @NotNull final EntityLivingBase placer, final EnumHand hand) { |
Raycoms
reviewed
Jul 8, 2018
| this(metaIn, nameIn, nameIn, mapColorIn); | ||
| } | ||
|
|
||
| BarrelType(final int metaIn, final String nameIn, final String unlocalizedNameIn, final MapColor mapColorIn) |
There was a problem hiding this comment.
javadoc for all public methods and fields please
Raycoms
reviewed
Jul 8, 2018
|
|
||
| /** | ||
| * Class used to handle the compost item. | ||
| */ | ||
| public class ItemCompost extends AbstractItemMinecolonies | ||
| { | ||
| /** | ||
| * Max stacksize of the item. | ||
| */ | ||
| private static final int MAX_STACK_SIZE = 64; |
There was a problem hiding this comment.
we have a constant for this somewhere already.
Raycoms
reviewed
Jul 8, 2018
| private static final int MAX_STACK_SIZE = 64; | ||
|
|
||
| /** | ||
| * Compost constructor, Set max stack size to 64 like all other items. | ||
| */ | ||
| public ItemCompost() |
Raycoms
reviewed
Jul 8, 2018
| { | ||
| private boolean done = false; | ||
| private int items = 0; | ||
| private int timer = 0; |
There was a problem hiding this comment.
jdoc for public methods and for all fields please.
Comments please in jdoc and not with // on next line
LDTTeam-Buildsystem
previously approved these changes
Jul 8, 2018
Fixing the formatting and adding JavaDoc where needed
LDTTeam-Buildsystem
dismissed
a stale review
A new analysis is being ran. Please wait for the results.
|
|
looks good for me now!
marchermans
previously approved these changes
Jul 10, 2018
All the item names and tags are defined in the same config entry. Added OreDictionary registries to the vanilla items where needed.
Wasn't checking the hole array of ids
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Review please