Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debian files and .gitignore #193

Merged
merged 4 commits into from
Feb 28, 2017
Merged

Conversation

fuhry
Copy link
Contributor

@fuhry fuhry commented Nov 11, 2016

  • Sync debian package version to upstream version
  • Add debhelper-generated files to .gitignore

* Sync debian package version to upstream version
* Add debhelper-generated files to .gitignore
@coveralls
Copy link

coveralls commented Nov 11, 2016

Coverage Status

Coverage decreased (-15.04%) to 44.724% when pulling e8999bc on fuhry:debian-files-update into edd1623 on ldx:master.

@fuhry
Copy link
Contributor Author

fuhry commented Nov 11, 2016

Hi @ldx! We at @datto are using your Python module for an internal project, and updated the build files for Ubuntu 16.04. We can build against my branch but as a rule we try to submit improvements back to upstream when possible.

Specifically could you let me know if you need the distro codename changed back, or other tweaks made to the control and changelog files? The python-support package was removed after Ubuntu 14.04, hence the removal of that dependency.

@ldx
Copy link
Owner

ldx commented Jan 3, 2017

@fuhry when I try to build a package from your branch it fails with:

 dpkg-source -b python-iptables
dpkg-source: error: can't build with source format '3.0 (native)': native package version may not have a revision
dpkg-buildpackage: error: dpkg-source -b python-iptables gave error exit status 255

This is on Debian 8. Seems dpkg does not like the new revision number 0.12.0-1. Changing it to 0.12.0.1 fixes the problem for me.

@fuhry
Copy link
Contributor Author

fuhry commented Feb 27, 2017

@ldx Sorry for the delay, but I've just fixed this and resolved the .gitignore conflicts. This should be ready to merge now.

@coveralls
Copy link

coveralls commented Feb 27, 2017

Coverage Status

Coverage increased (+14.8%) to 59.975% when pulling d0fab0d on fuhry:debian-files-update into a71f64f on ldx:master.

Fixes module import on older Ubuntu releases
@coveralls
Copy link

coveralls commented Feb 27, 2017

Coverage Status

Coverage increased (+14.8%) to 59.975% when pulling e947af1 on fuhry:debian-files-update into a71f64f on ldx:master.

@ldx
Copy link
Owner

ldx commented Feb 28, 2017

Thanks!

@ldx ldx merged commit f8d1df6 into ldx:master Feb 28, 2017
@drzraf drzraf mentioned this pull request May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants