Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ansible #56

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Upgrade Ansible #56

merged 11 commits into from
Jul 16, 2024

Conversation

pierreboissinot
Copy link
Member

No description provided.

lucasmirloup
lucasmirloup requested changes Jul 5, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@pierreboissinot @lucasmirloup
Update docker/Dockerfile
96132ad 
Co-authored-by: Lucas Mirloup <97196064+lucasmirloup@users.noreply.github.com>
lucasmirloup
lucasmirloup previously approved these changes Jul 5, 2024
View reviewed changes
@pierreboissinot pierreboissinot dismissed lucasmirloup’s stale review July 5, 2024 08:21

The merge-base changed after approval.

thislg
thislg requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@thislg thislg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La branche n'est pas à jour (on voit des modifs concernant la 1.12.3 qui ont été mergées sur l'autre PR).

@pierreboissinot
Copy link
Member Author

La branche n'est pas à jour (on voit des modifs concernant la 1.12.3 qui ont été mergées sur l'autre PR).

Ok.

thislg
thislg requested changes Jul 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pierreboissinot @thislg
Update CHANGELOG.md
ab551ce 
Co-authored-by: Thibaut Selingue <thibaut.selingue@lephare.com>
thislg
thislg previously approved these changes Jul 5, 2024
View reviewed changes
@pierreboissinot pierreboissinot dismissed thislg’s stale review July 5, 2024 09:20

The merge-base changed after approval.

@pierreboissinot
Copy link
Member Author

@thislg suivant vos agendas dites-moi mais je peux tester la v2.0.0 cet aprem, la semaine pro je suis en congés.

@thislg thislg self-requested a review July 5, 2024 09:21
thislg
thislg previously approved these changes Jul 5, 2024
View reviewed changes
@pierreboissinot pierreboissinot dismissed thislg’s stale review July 5, 2024 09:44

The merge-base changed after approval.

lucasmirloup
lucasmirloup previously approved these changes Jul 5, 2024
View reviewed changes
@pierreboissinot pierreboissinot dismissed lucasmirloup’s stale review July 5, 2024 10:01

The merge-base changed after approval.

@pierreboissinot
Copy link
Member Author

@lucasmirloup @thislg

Merci, je me suis mis un rappel pour le 15/07 afin de update la date sur le changelog et merge + tester la nouvelle version sur un projet.

@thislg
Copy link
Member

thislg commented Jul 5, 2024

Et dans la mesure du possible il faudrait tester sur un projet avant de taguer la version.

@pierreboissinot
Copy link
Member Author

Et dans la mesure du possible il faudrait tester sur un projet avant de taguer la version.

Ce ne sera pas possible de mon côté, les projets IMA ne sont pas déployable hors CI/CD.
Je demanderai à l'un de vous deux de build en local et de tester un déploiement en preprod vers un server post 2022 (qui a python3).

@thislg
Copy link
Member

thislg commented Jul 5, 2024 •
edited
Loading

Tous les commits push donnent lieu à une image docker que tu peux renseigner dans ta configuration Ansible : https://hub.docker.com/layers/lephare/ansible/upgrade-ansible/images/sha256-313b19ce6bee082f82cc2acc2344b63a001eae44212c4d878f8b937aaca52b0d?context=explore (mais ça n'empêche pas qu'on teste en local avant).

@pierreboissinot
Copy link
Member Author

@thislg @lucasmirloup changelog updated, test réussi sur un serveur avec Python 3.9.2.

J'ai corrigé une erreur dans le readme également

lucasmirloup
lucasmirloup previously approved these changes Jul 16, 2024
View reviewed changes
@pierreboissinot pierreboissinot dismissed lucasmirloup’s stale review July 16, 2024 12:36

The merge-base changed after approval.

@pierreboissinot
Copy link
Member Author

merci pour les reviews

@pierreboissinot pierreboissinot merged commit 849d4cc into master Jul 16, 2024
1 check passed
@lucasmirloup lucasmirloup deleted the upgrade-ansible branch September 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmirloup lucasmirloup lucasmirloup approved these changes

@thislg thislg thislg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierreboissinot @thislg @lucasmirloup