New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote images for timeline - suggestion/workaround #46

Closed
altsheets opened this Issue Nov 7, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@altsheets

altsheets commented Nov 7, 2015

I am allowing external images in my timeline, then {{site.baseurl}} must not be prepended. My workaround is not the most elegant (that would be testing the variable "image" for "http(s)://") ... but it works. For remote images, I define a {{event.imageremote}} in _config.yml

events:
  - image: "https://media.giphy.com....gif" 
    imageremote: True

and insert a test into career.html

<img class="img-circle img-responsive" src="{% unless event.imageremote %}{{ site.baseurl }}{%endunless%}{{ event.image }}" alt="">

so all the other (=local) images do get {{ site.baseurl }} prepended.

It works, so I thought, why not share it with you guys.

Many many thanks for all the work you put into this. My new site looks great!

@le4ker

This comment has been minimized.

Show comment
Hide comment
@le4ker

le4ker Nov 8, 2015

Owner

I see, but I really believe that the images should be local, because if for example the remote image suddenly changes it can mess up your website, if for example is not a square 😉

Avoid taking dependencies, as always 😉

Thanks for the feedback!
I had no idea that the repo would be used by so many people, and that's great!
Let's make the web a better place 😉

Owner

le4ker commented Nov 8, 2015

I see, but I really believe that the images should be local, because if for example the remote image suddenly changes it can mess up your website, if for example is not a square 😉

Avoid taking dependencies, as always 😉

Thanks for the feedback!
I had no idea that the repo would be used by so many people, and that's great!
Let's make the web a better place 😉

@le4ker le4ker closed this Nov 8, 2015

@altsheets

This comment has been minimized.

Show comment
Hide comment
@altsheets

altsheets Nov 8, 2015

Thanks a lot! Yes, I get your point. Still, I want to link to external content. And already built that extension described above, anyways.

I had no idea that the repo would be used by so many people, and that's great!

Yes. Before I started, I compared a lot of different themes. And yours was closest to what I wanted to build. And beautiful, too.

Here, have a look: My new website is launched - http://altsheets.ddns.net/assetgraphs/v2/products/ - using your theme as the basis, and then going wild on modifying it.

Thank you so much for your theme. I worked a lot on it, to adapt it to my needs, and fix some problems - but your underlying design was already so great, that it looks quite nice, I think.

Let's make the web a better place

Yes. And a happy place :-)


EDIT: The very last link at the bottom of my page links back to your github, to this theme repo. Is that appropriate like it is? Or should I mention your name, too?

altsheets commented Nov 8, 2015

Thanks a lot! Yes, I get your point. Still, I want to link to external content. And already built that extension described above, anyways.

I had no idea that the repo would be used by so many people, and that's great!

Yes. Before I started, I compared a lot of different themes. And yours was closest to what I wanted to build. And beautiful, too.

Here, have a look: My new website is launched - http://altsheets.ddns.net/assetgraphs/v2/products/ - using your theme as the basis, and then going wild on modifying it.

Thank you so much for your theme. I worked a lot on it, to adapt it to my needs, and fix some problems - but your underlying design was already so great, that it looks quite nice, I think.

Let's make the web a better place

Yes. And a happy place :-)


EDIT: The very last link at the bottom of my page links back to your github, to this theme repo. Is that appropriate like it is? Or should I mention your name, too?

@le4ker

This comment has been minimized.

Show comment
Hide comment
@le4ker

le4ker Nov 9, 2015

Owner

The credits are totally fine like this, don't worry 😉

Owner

le4ker commented Nov 9, 2015

The credits are totally fine like this, don't worry 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment