Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Add CDN of github release download #28

Closed
wants to merge 1 commit into from

Conversation

SOVLOOKUP
Copy link

This will make caxa much more friendly to users who cannot access GitHub due to network reasons.

The logic:

  1. Identify country through http://api.hostip.info/country.php
  2. Search mirror doamin from mirror object and if not exist, fallback to github.com
  3. download

This will make caxa much more friendly to users who cannot access GitHub due to network reasons.

The logic:
1. Identify country through http://api.hostip.info/country.php
2. Search mirror doamin from mirror object and if not exist, fallback to github.com
3. download
@leafac
Copy link
Owner

leafac commented Jun 12, 2021

Thanks for the work on this pull request.

What do you think of these alternatives:

  1. Ship the stub along with the npm package. The downside is that it’s ~20MB to download, but it simplifies the whole process.
  2. Instead of querying an external service to get the country, let the user provide a mirror as an installation option.

@papb
Copy link

papb commented Jun 13, 2021

Instead of querying an external service to get the country, let the user provide a mirror as an installation option.

Hello! I am not OP but just wanted to say I like this.

@SOVLOOKUP SOVLOOKUP closed this Jun 18, 2021
@leafac
Copy link
Owner

leafac commented Jun 25, 2021

caxa@2.1 is out and the stubs are shipped in the npm package—there’s no need for GitHub Releases downloads anymore. Please let me know how it works for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants