Add support for X509 signature algorithms such as RSA-SHA1 and ECDSA-with-SHA384 #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ECDSA certificate, the signature name is the full name (e.g., ecdsa-with-SHA384), but indeed should be the digest part only (e.g., SHA384). Similarly, RSA-SHA1 is broken now because it doesn't start with SHA1 hence it doesn't get replace with SHA256.
This PR fixes both of these problems.
It's an alternative proposal to #127 that works for all socket types but I didn't touch cqueues because I was not sure why it was hardcoded as SHA256.