Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CustomerServiceTickets & GlobalNav #229

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

sdjdd
Copy link
Contributor

@sdjdd sdjdd commented Mar 22, 2021

See #213

  • 重写 CustomerServiceTickets 、GlobalNav 组件
  • 时间区间新增「今日」
  • 新增两个配置
    • 顶部导航优先级
    • 顶部导航链接
  • 修复第一次加载时不能正确将客服导航至客服工单列表页的问题
  • 修复未设置 SUPPORT_EMAIL 全局变量时无法显示错误页的问题

@sdjdd sdjdd requested a review from leeyeh March 22, 2021 08:37
@sdjdd sdjdd changed the title refactor(CustomerServiceTickets): prefer react hook refactor: CustomerServiceTickets & GlobalNav Mar 22, 2021
const user = await new AV.Query(AV.User)
.equalTo('username', username)
.first({ useMasterKey: true })
if (!user) {
throw new AV.Cloud.Error('Not Found', { status: 404 })
return null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前端根据是否返回 null 判断用户是否存在,之前改错了。

@leeyeh
Copy link
Contributor

leeyeh commented Mar 22, 2021

太长不看求链接

@sdjdd
Copy link
Contributor Author

sdjdd commented Mar 23, 2021

太长不看求链接

已部署到 sdjdd-ticket 的生产环境。

@leeyeh
Copy link
Contributor

leeyeh commented Mar 23, 2021

顶部导航优先级

这个的调整体现在哪里了?

@sdjdd
Copy link
Contributor Author

sdjdd commented Mar 24, 2021

https://github.com/leancloud/ticket/pull/229/files#diff-45d39c0a2c8e3e4763af93b76be1a8caade70011a11af152825ba7ef02a2a00cR124

是说可以通过调整优先级的配置改变导航的顺序。

@sdjdd sdjdd merged commit 47db2c5 into leancloud:master Mar 24, 2021
@sdjdd sdjdd deleted the feat/some-optimization branch March 24, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants