Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cid 1912 fix duplicate runs #72

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Feature/cid 1912 fix duplicate runs #72

merged 6 commits into from
Sep 11, 2023

Conversation

henriqamaral
Copy link
Contributor

  • Improved logs
  • Add hostname on vsm calls

@henriqamaral henriqamaral self-assigned this Sep 7, 2023
@henriqamaral henriqamaral requested a review from a team as a code owner September 7, 2023 14:13
@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

VSM Github Broker Code Coverage

File Coverage [65.22%] 🍏
GitHubWebhookService.kt 86.77% 🍏
MtmFeignClientConfiguration.kt 82.2% 🍏
BaseConnectorService.kt 62% 🍏
InitialStateRunner.kt 57.26% ❌
ScheduleRepositories.kt 13.84% ❌
NoWebhookService.kt 0% ❌
Total Project Coverage 76.34% 🍏

ahmed-ali-55
ahmed-ali-55 approved these changes Sep 11, 2023
View reviewed changes
Copy link

@ahmed-ali-55 ahmed-ali-55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one thing mentioned below

src/main/kotlin/net/leanix/vsm/githubbroker/connector/application/RepositoriesService.kt Outdated Show resolved Hide resolved
@henriqamaral henriqamaral merged commit 503a931 into main Sep 11, 2023
2 checks passed
@henriqamaral henriqamaral deleted the feature/cid-1912-fix-duplicate-runs branch September 11, 2023 09:17
@henriqamaral henriqamaral mentioned this pull request Sep 11, 2023
Merged
henriqamaral pushed a commit that referenced this pull request Sep 12, 2023
@henriq-amaral-leanix
v1.6.0
92c535f 
## What's Changed

* CID-1912: Add more message logs @henriqamaral in #72
* CID-1912: Add hostname on vsm-calls@henriqamaral in #72
* CID-1912: Remove get assignments on scheduler @henriqamaral in #72


**Full Changelog**: v1.5.1...v1.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-ali-55 ahmed-ali-55 ahmed-ali-55 approved these changes

Assignees

@henriqamaral henriqamaral

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henriqamaral @ahmed-ali-55