-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to 2023-01-10 nightly #38
Closed
Ruben-VandeVelde
wants to merge
13
commits into
leanprover-community:master
from
Ruben-VandeVelde:up-2023-01-10
Closed
chore: update to 2023-01-10 nightly #38
Ruben-VandeVelde
wants to merge
13
commits into
leanprover-community:master
from
Ruben-VandeVelde:up-2023-01-10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ruben-VandeVelde
commented
Jan 10, 2023
•
edited
Loading
edited
- depends on chore: update to 2023-01-10 nightly batteries#83
This was referenced Jan 10, 2023
Test failure is likely due to leanprover-community/batteries@9fb26e5 - should I just remove the test? |
I'll fix the test. I'll also remove some more stuff that is now in std but under different names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Merged. Thank you so much! |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 10, 2023
- [x] depends on: leanprover-community/batteries#83 - [x] depends on: leanprover-community/aesop#38
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 10, 2023
- [x] depends on: leanprover-community/batteries#83 - [x] depends on: leanprover-community/aesop#38 - [x] depends on: #1447 Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
jcommelin
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 23, 2023
- [x] depends on: leanprover-community/batteries#83 - [x] depends on: leanprover-community/aesop#38
jcommelin
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 23, 2023
- [x] depends on: leanprover-community/batteries#83 - [x] depends on: leanprover-community/aesop#38 - [x] depends on: #1447 Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.