Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename Classical.and_not #612

Merged
merged 1 commit into from
Feb 10, 2024
Merged

chore: rename Classical.and_not #612

merged 1 commit into from
Feb 10, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Feb 10, 2024

We just added Classical.and_not, but it is causing too many disambiguation errors with _root_.and_not in Mathlib, so I am giving it a longer name.

@kim-em kim-em merged commit bdf1213 into main Feb 10, 2024
2 checks passed
@kim-em
Copy link
Collaborator Author

kim-em commented Feb 10, 2024

Apologies, I am just going to merge this myself, as I really want to get Mathlib's nightly-testing working again, and don't want to have to do all the _root_.not_and disambiguation in Mathlib needlessly.

Please ping me and I'm happy to do another name change later if it is needed.

@digama0
Copy link
Member

digama0 commented Feb 10, 2024

Can mathlib just re-export the theorem instead of defining an alias?

alexkeizer pushed a commit to opencompl/std4 that referenced this pull request Feb 12, 2024
fgdorais pushed a commit to fgdorais/batteries that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants