-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdbook setup #121
mdbook setup #121
Conversation
This idea in theory seems reasonable to me but I think there's a few things to work out. Specifically if we do this, it seems like we should avoid duplicating the README in the SUMMARY.md, as they'll easily go out of sync. Both would be being used for similar purposes -- the README, besides being human-readable, is also used for indicating the order of pages for the PDF which we build via Moreover, I think mdbook still doesn't support outputting PDF files (rust-lang/mdBook#815), and really if we do use something like (P.S. -- If we do get to merging this, we'll need help from someone with full permissions on the repository, as I don't see the Settings tab here. We can ping them if/when we're ready to merge I think. |
I tried the reasons are:
|
OK -- I'm fine with it if it didn't work out (thanks for trying), though I don't really agree with duplication not being a significant problem -- I think no one will remember/know to update both when contributing changes as-is. At very minimum we need to clearly write in the README that updates need to go in both places, but even better would likely be symlinking one to the other. EDIT: Though I guess the symlinking won't work well, because the links will all be broken once the md directory is deleted. So somehow we either need to make it very hard to forget, or else to write very clearly that someone needs to do this. |
deleted (sorry) |
What about using a separate workflow to generate one from the other, Readme and Summary? |
All of the above are also OK with me (including not doing them in this specific PR!) |
Thank you very much. In this pull request, I will concentrate on adding the ability to host web pages by mdbook. |
Cool, thanks again for the PR and the work! I think this is basically ready to merge then after you back out the |
@Julian I have set up the workflow. Please check it out. |
This PR also resolves #113. |
Great! This looks mergeable to me. Well done. Now we need someone to enable pages I think, assuming it's ok with folks that this then lives on https://leanprover-community.github.io. @jcommelin / @PatrickMassot / @eric-wieser / @semorrison assuming one of you have higher perms on this repository and are OK with doing so (making the book available at https://leanprover-community.github.io/lean4-metaprogramming-book/) can you tick the box in Settings to enable GitHub pages? |
I did it, guessing you want to deploy using GitHub actions. |
Great, thanks Patrick! @Seasawher let's see how it goes, hitting the big green button. |
Nice! Looks like it built! https://leanprover-community.github.io/lean4-metaprogramming-book/ is live. Thanks again! |
Thank you very much! It would be better if the URL was written in a place where it could be easily found, e.g. in the description section of the repository. |
I asked Patrick to do so over DM when I merged, he'll help out when he's got another moment I'm sure. |
resolve #64
I have used mdbook to host this book as web pages.
For deployment, please use github actions instead of branch deploying.