-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(topology/metric_space/hausdorff_distance): add definition and lemmas about closed thickenings of subsets #10542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a relation between closure (thickening δ E)
and cthickening δ E
you could add? There should be at least an inclusion, perhaps even equality?
Yes --- only the inclusion, though. I can add this inclusion, either in this PR or a follow-up. I will in any case be following up with more on thickenings (at least as much as is needed for the portmanteau theorem); I just wanted to split to manageable size PR chunks. Is it better to add this in the present PR or a follow-up? |
The inclusion can be kept for later if you want. Let's change the |
Another thing that I should eventually add, but originally thought of including in a follow-up, is the In this regard the order in my PRs was probably suboptimal, since the proof of Again the main question is if more should be included in this PR, or should these be in follow-ups. I am trying to keep individual PRs small. [Edit: After a bit of thinking, my preference is now to do an extremely minor change to replace the two last lemmas in this PR by their closed thickening counterparts. This should mean there is no need to touch them again in the follow-up. I did that now in 83d2dc1, hopefully ok?] |
… versions to optimize follow-up.
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
Thanks. let's wait for CI and merge. |
✌️ kkytola can now approve this pull request. To approve and merge a pull request, simply reply with |
Thank you! bors r+ |
…mmas about closed thickenings of subsets (#10542) Add definition and basic API about closed thickenings of subsets in metric spaces, in preparation for the portmanteau theorem on characterizations of weak convergence of Borel probability measures. Co-authored-by: kkytola <39528102+kkytola@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
…mmas about closed thickenings of subsets (#10542) Add definition and basic API about closed thickenings of subsets in metric spaces, in preparation for the portmanteau theorem on characterizations of weak convergence of Borel probability measures. Co-authored-by: kkytola <39528102+kkytola@users.noreply.github.com>
Add definition and basic API about closed thickenings of subsets in metric spaces, in preparation for the portmanteau theorem on characterizations of weak convergence of Borel probability measures.
This is a continuation of a (rather independent) part of my attempt to PR a proof of the portmanteau theorem https://github.com/kkytola/lean_portmanteau. Specifically it is intended as an improved and cleaned up version of a manageable size chunck of the file https://github.com/kkytola/lean_portmanteau/blob/main/portmanteau_metric_lemmas.lean.
For portmanteau purposes, this PR still needs to be followed up by some further API, in particular continuous approximations of indicator functions of closed sets, and crucially, the countability of thickening-radii such that the boundary of the thickening carries a positive measure w.r.t. a given Borel probability measure.