Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/metric_space/hausdorff_distance): add definition and lemmas about closed thickenings of subsets #10542

Closed
wants to merge 10 commits into from

Conversation

kkytola
Copy link
Collaborator

@kkytola kkytola commented Nov 29, 2021

Add definition and basic API about closed thickenings of subsets in metric spaces, in preparation for the portmanteau theorem on characterizations of weak convergence of Borel probability measures.


This is a continuation of a (rather independent) part of my attempt to PR a proof of the portmanteau theorem https://github.com/kkytola/lean_portmanteau. Specifically it is intended as an improved and cleaned up version of a manageable size chunck of the file https://github.com/kkytola/lean_portmanteau/blob/main/portmanteau_metric_lemmas.lean.

For portmanteau purposes, this PR still needs to be followed up by some further API, in particular continuous approximations of indicator functions of closed sets, and crucially, the countability of thickening-radii such that the boundary of the thickening carries a positive measure w.r.t. a given Borel probability measure.

Open in Gitpod

@kkytola kkytola added the awaiting-review The author would like community review of the PR label Nov 29, 2021
Copy link
Collaborator

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a relation between closure (thickening δ E) and cthickening δ E you could add? There should be at least an inclusion, perhaps even equality?

src/topology/metric_space/hausdorff_distance.lean Outdated Show resolved Hide resolved
@kkytola
Copy link
Collaborator Author

kkytola commented Dec 3, 2021

Is there a relation between closure (thickening δ E) and cthickening δ E you could add? There should be at least an inclusion, perhaps even equality?

Yes --- only the inclusion, though. I can add this inclusion, either in this PR or a follow-up. I will in any case be following up with more on thickenings (at least as much as is needed for the portmanteau theorem); I just wanted to split to manageable size PR chunks.

Is it better to add this in the present PR or a follow-up?

@RemyDegenne
Copy link
Collaborator

The inclusion can be kept for later if you want. Let's change the thickening_subset_cthickening lemma and merge this.

@kkytola
Copy link
Collaborator Author

kkytola commented Dec 3, 2021

Another thing that I should eventually add, but originally thought of including in a follow-up, is the cthickening versions of cthickening_eq_Inter_thickening and closure_eq_Inter_thickening, i.e., lemmas called cthickening_eq_Inter_cthickening and closure_eq_Inter_cthickening.

In this regard the order in my PRs was probably suboptimal, since the proof of cthickening_eq_Inter_cthickening should probably be given first (essentially the same as cthickening_eq_Inter_thickening in this PR) and then the open thickening case follows simply from it. In any case I would refactor, but one possibility is to change this PR very slightly to do the closed thickening case instead of the open thickening case. Or I could do both, by adding two more lemmas.

Again the main question is if more should be included in this PR, or should these be in follow-ups. I am trying to keep individual PRs small.

[Edit: After a bit of thinking, my preference is now to do an extremely minor change to replace the two last lemmas in this PR by their closed thickening counterparts. This should mean there is no need to touch them again in the follow-up. I did that now in 83d2dc1, hopefully ok?]

@RemyDegenne
Copy link
Collaborator

Thanks. let's wait for CI and merge.
bors d+

@bors
Copy link

bors bot commented Dec 3, 2021

✌️ kkytola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 3, 2021
@kkytola
Copy link
Collaborator Author

kkytola commented Dec 3, 2021

Thank you!

bors r+

bors bot pushed a commit that referenced this pull request Dec 3, 2021
…mmas about closed thickenings of subsets (#10542)

Add definition and basic API about closed thickenings of subsets in metric spaces, in preparation for the portmanteau theorem on characterizations of weak convergence of Borel probability measures.



Co-authored-by: kkytola <39528102+kkytola@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/metric_space/hausdorff_distance): add definition and lemmas about closed thickenings of subsets [Merged by Bors] - feat(topology/metric_space/hausdorff_distance): add definition and lemmas about closed thickenings of subsets Dec 3, 2021
@bors bors bot closed this Dec 3, 2021
@bors bors bot deleted the kkytola/thickenings_2 branch December 3, 2021 16:11
jcommelin pushed a commit that referenced this pull request Dec 18, 2021
…mmas about closed thickenings of subsets (#10542)

Add definition and basic API about closed thickenings of subsets in metric spaces, in preparation for the portmanteau theorem on characterizations of weak convergence of Borel probability measures.



Co-authored-by: kkytola <39528102+kkytola@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants