Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group_theory/presented_group): define presented groups #1118

Merged
merged 13 commits into from
Jun 10, 2019
Merged

feat(group_theory/presented_group): define presented groups #1118

merged 13 commits into from
Jun 10, 2019

Conversation

Michael-Howes
Copy link
Collaborator

@Michael-Howes Michael-Howes commented Jun 7, 2019

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

Michael Howes and others added 6 commits May 15, 2019 16:05
define group conjugates and normal closure
Presented groups are defined as a quotient of a free group by the normal subgroup  the relations generate.
Presented groups are defined as a quotient of a free group by the normal subgroup  the relations generate
@Michael-Howes Michael-Howes requested a review from a team as a code owner June 7, 2019 04:24
@khoek khoek changed the title Define presented groups feat(group_theory/conjugates): define conjugates Jun 7, 2019
@khoek khoek changed the title feat(group_theory/conjugates): define conjugates feat(group_theory\presented_group): define presented groups Jun 7, 2019
@khoek
Copy link
Collaborator

khoek commented Jun 7, 2019

(mergify uses the title for the commit message, I think)

@Michael-Howes Michael-Howes changed the title feat(group_theory\presented_group): define presented groups feat(group_theory/presented_group): define presented groups Jun 7, 2019
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the entirety of the universal property. We also need the (easy) fact that the extension is unique (amongst homomorphisms sending the generators to the specified places).

Copy link
Member

@ChrisHughes24 ChrisHughes24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also complete the UMP by defining the map of : α -> presented_group rels and the proof that to_group f (of a) = f a

src/group_theory/presented_group.lean Outdated Show resolved Hide resolved
src/group_theory/presented_group.lean Outdated Show resolved Hide resolved
src/group_theory/presented_group.lean Outdated Show resolved Hide resolved
src/group_theory/presented_group.lean Outdated Show resolved Hide resolved
@Michael-Howes
Copy link
Collaborator Author

I've now added the definition of of : α → presented_group rels, a theorem saying that the extension is unique and some simp lemmas about the extension.

Copy link
Member

@ChrisHughes24 ChrisHughes24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments about names.

src/group_theory/presented_group.lean Show resolved Hide resolved
src/group_theory/presented_group.lean Outdated Show resolved Hide resolved
src/group_theory/presented_group.lean Show resolved Hide resolved
@ChrisHughes24 ChrisHughes24 added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 10, 2019
@mergify mergify bot merged commit bd2f35f into leanprover-community:master Jun 10, 2019
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…er-community#1118)

* feat(group_theory/conjugates) : define conjugates
define group conjugates and normal closure

* feat(algebra/order_functions): generalize strict_mono.monotone (leanprover-community#1022)

* trying to merge

* feat(group_theory\presented_group):  define presented groups

Presented groups are defined as a quotient of a free group by the normal subgroup  the relations generate.

* feat(group_theory\presented_group): define presented groups

Presented groups are defined as a quotient of a free group by the normal subgroup  the relations generate

* Update src/group_theory/presented_group.lean

Co-Authored-By: Keeley Hoek <keeley@hoek.io>

* Uniqueness of extension

* Tidied up to_group.unique

* Removed unnecessary line

* Changed naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants