[Merged by Bors] - feat(data/nat/modeq): add modeq and dvd lemmas from Apostol Chapter 5 #11787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we sure these theorems or anything similar to them aren't in mathlib already? They all seem pretty basic. |
|
They do, but I couldn't resolve them with |
vihdzp
requested changes
Feb 3, 2022
stuart-presnell
added
the
awaiting-review
|
@vihdzp I think I've addressed all your comments now. Thanks very much for your helpful suggestions, especially the suggested lemma names. |
kmill
reviewed
Feb 8, 2022
kmill
reviewed
Feb 8, 2022
kmill
changed the title
|
Thanks @stuart-presnell for the PR and @vihdzp for the detailed review! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
…#11787) Various lemmas about `modeq` from Chapter 5 of Apostol (1976) Introduction to Analytic Number Theory: * `mul_left_iff` and `mul_right_iff`: Apostol, Theorem 5.3 * `dvd_iff_of_modeq_of_dvd`: Apostol, Theorem 5.5 * `gcd_eq_of_modeq`: Apostol, Theorem 5.6 * `eq_of_modeq_of_abs_lt`: Apostol, Theorem 5.7 * `modeq_cancel_left_div_gcd`: Apostol, Theorem 5.4; plus other cancellation lemmas following from this.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various lemmas about
modeqfrom Chapter 5 of Apostol (1976) Introduction to Analytic Number Theory:mul_left_iffandmul_right_iff: Apostol, Theorem 5.3dvd_iff_of_modeq_of_dvd: Apostol, Theorem 5.5gcd_eq_of_modeq: Apostol, Theorem 5.6eq_of_modeq_of_abs_lt: Apostol, Theorem 5.7modeq_cancel_left_div_gcd: Apostol, Theorem 5.4; plus other cancellation lemmas following from this.