-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(algebra/ring): use curly brackets for ring_hom where possible #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Let's try to document why we are doing this somewhere, because using implicit arguments like this is not an obvious choice. I suggest writing a Note /- Note [instances as implicit arguments]
... -- try to discuss what goes wrong with [] arguments, or why it leads to wasted effort by Lean in specific examples
-/ Specializing to |
7 tasks
ChrisHughes24
added
the
awaiting-review
The author would like community review of the PR
label
Oct 9, 2019
semorrison
reviewed
Oct 11, 2019
semorrison
reviewed
Oct 11, 2019
jcommelin
approved these changes
Oct 11, 2019
jcommelin
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 11, 2019
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…eanprover-community#1525) * chore(algebra/ring): use curly brackets for ring_hom where possible * add comments explaining motivation * move explanation to header * fix build * Update src/algebra/ring.lean * scott's suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list