This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(algebra/order/with_zero): Move unrelated lemmas #15676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
YaelDillies
removed
the
awaiting-CI
jcommelin
reviewed
Aug 4, 2022
| @@ -49,7 +49,7 @@ A `pow` form of `nat.factorization_choose_le` | |||
| lemma pow_factorization_choose_le (hn : 0 < n) : p ^ (choose n k).factorization p ≤ n := | |||
| begin | |||
| cases le_or_lt p 1, | |||
| { exact (pow_le_pow_of_le h).trans ((le_of_eq (one_pow _)).trans hn) }, | |||
| { exact (pow_le_pow_of_le_left' h _).trans ((le_of_eq (one_pow _)).trans hn) }, | |||
There was a problem hiding this comment.
No, I deleted pow_le_pow_of_le because it duplicates pow_le_pow_of_le_left'.
jcommelin
reviewed
Aug 4, 2022
| @@ -106,7 +106,7 @@ end | |||
| @[simp, to_additive] | |||
| lemma prod_take_mul_prod_drop : | |||
| ∀ (L : list M) (i : ℕ), (L.take i).prod * (L.drop i).prod = L.prod | |||
| | [] i := by simp | |||
| | [] i := by simp [@zero_le' ℕ] | |||
There was a problem hiding this comment.
These @zero_le' ℕ are somewhat ugly. Can you fix that regression please?
There was a problem hiding this comment.
Not sure how... This is a bug in to_additive that shows only now because of the import changes.
There was a problem hiding this comment.
this has come up before in #10767
1 task
jcommelin
added
awaiting-author
YaelDillies
added
awaiting-review
ericrbg
approved these changes
Aug 21, 2022
| @@ -106,7 +106,7 @@ end | |||
| @[simp, to_additive] | |||
| lemma prod_take_mul_prod_drop : | |||
| ∀ (L : list M) (i : ℕ), (L.take i).prod * (L.drop i).prod = L.prod | |||
| | [] i := by simp | |||
| | [] i := by simp [@zero_le' ℕ] | |||
There was a problem hiding this comment.
this has come up before in #10767
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
Move a bunch of lemmas that were not about `whatever_with_zero` from `algebra.order.with_zero` to `algebra.group_power.order`. Delete `nat.le_zero_iff` in favor of `le_zero_iff`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move a bunch of lemmas that were not about
whatever_with_zerofromalgebra.order.with_zerotoalgebra.group_power.order. Deletenat.le_zero_iffin favor ofle_zero_iff.This is preparatory work to be able to import
algebra.order.with_zeroearlier (in particular inalgebra.order.field).