New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(data/rat/order): remove dependencies #17384
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
The author would like community review of the PR
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Nov 6, 2022
1 task
semorrison
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Nov 7, 2022
This PR/issue depends on: |
bors d+ |
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 7, 2022
5 tasks
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Nov 7, 2022
bors bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
…17408 (#17405) This is going to be another combination PR. If at any point every constituent PR has been delegated, and I have a green check here, I will hand it to bors (i.e. without waiting for an explicit approval of this PR). The only difference relative to the constituent PRs are any further import adjustments required to keep everything working together. Using this PR means I can locally build everything together to check for interactions. Depends on * [X] #17384 * [X] #17398 * [ ] #17406 * [ ] #17407 * [ ] #17408 Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits
data.rat.defs
intodata.rat.defs
anddata.rat.lemmas
, essentially deferring everything that isn't needed fordata.rat.order
. This saves us a few more imports fordata.rat.order
.