refactor(algebra/ring/basic): split out algebra.ring.defs #17407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
5 tasks
|
If anyone is tempted, some of the files which now import |
1 task
semorrison
removed
the
awaiting-CI
2 tasks
|
I'm later going to adjust the division of material made in this file. This PR is far from optimal. But if we could just approve as is, it will save me a lot of waiting for CI. :-) |
|
bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
bors bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
…17408 (#17405) This is going to be another combination PR. If at any point every constituent PR has been delegated, and I have a green check here, I will hand it to bors (i.e. without waiting for an explicit approval of this PR). The only difference relative to the constituent PRs are any further import adjustments required to keep everything working together. Using this PR means I can locally build everything together to check for interactions. Depends on * [X] #17384 * [X] #17398 * [ ] #17406 * [ ] #17407 * [ ] #17408 Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an
algebra.ring.defswhose only imports arealgebra.group_with_zero.defsanddata.int.cast.defs, following the pattern forgroupandgroup_with_zero.(Note currently in master
data.int.cast.defshas acquired some theory imports, but this is fixed in #17406.)This will be merged as part of #17405, so please delegate rather than merge.