Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data/set): fixes that should have been in #17381 #17398

Closed
wants to merge 157 commits into from
Closed

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Nov 6, 2022

#17381 is a "supremum" PR, trying to get many overlapping changes to imports merged, after it became clear that merging them individually was scaling quadratically...

In the interests of getting CI through, some corrections to that PR have been deferred here.

Open in Gitpod

@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. awaiting-CI The author would like to see what CI has to say before doing more work. labels Nov 6, 2022
@semorrison semorrison requested review from a team as code owners November 6, 2022 23:12
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@fpvandoorn
Copy link
Member

bors d+
(feel free to skip the other one and merge this one first, unless you had much bigger plans for this one)

@bors
Copy link

bors bot commented Nov 7, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Nov 7, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 7, 2022
bors bot pushed a commit that referenced this pull request Nov 8, 2022
…17408 (#17405)

This is going to be another combination PR. If at any point every constituent PR has been delegated, and I have a green check here, I will hand it to bors (i.e. without waiting for an explicit approval of this PR).

The only difference relative to the constituent PRs are any further import adjustments required to keep everything working together. Using this PR means I can locally build everything together to check for interactions.

Depends on
* [X] #17384
* [X] #17398
* [ ] #17406 
* [ ] #17407
* [ ] #17408



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@semorrison semorrison closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants