Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

refactor(analysis/calculus/local_extr): split file #19124

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 29, 2023

UPD: I'm going to redo this PR in mathlib 4 after the port. I'm leaving it here as a reminder.

Split analysis.calculus.local_extr into 4 files

  • analysis.calculus.local_extr.basic: positive tangent cone and Fermat theorem.
  • topology.algebra.order.rolle: topological part of Rolle's Theorem.
  • analysis.calculus.local_extr.rolle: Rolle's Theorem.
  • analysis.calculus.local_extr.polynomial: applications to roots of real polynomials.

API changes

  • Generalize exists_Ioo_extr_on_Icc and exists_local_extr_Ioo.
  • Add exists_extr_on_Ioo_of_tendsto and exists_is_local_extr_Ioo_of_tendsto.
  • Make f and f' implicit in all versions of Rolle's Theorem.

Open in Gitpod

@urkud urkud added the WIP Work in progress label May 29, 2023
@urkud urkud added awaiting-review The author would like community review of the PR mathport For compatibility with Lean 4 changes, to simplify porting t-analysis Analysis (normed *, calculus) WIP Work in progress and removed WIP Work in progress awaiting-review The author would like community review of the PR mathport For compatibility with Lean 4 changes, to simplify porting labels May 29, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIven you're an author on these files I trust you that this is a sensible split.

bors d+

@bors
Copy link

bors bot commented May 29, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label May 29, 2023
@kim-em kim-em added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@urkud urkud closed this Jul 19, 2023
@urkud urkud deleted the YK-local-extr-split branch July 19, 2023 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
delegated The PR author may merge after reviewing final suggestions. t-analysis Analysis (normed *, calculus) too-late This PR was ready too late for inclusion in mathlib3 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants