Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/set/finite): add a version of prod_preimage for inj_on #3342

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 9, 2020

  • rename finset.prod_preimage to finset.prod_preimage_of_bij;
  • new prod_preimage assumes ∀ x ∈ s, x ∉ range f, g x = 1;
  • rename finset.image_preimage to finset.image_preimage_of_bij;
  • new finset.image_preimage says
    image f (preimage s hf) = s.filter (λ x, x ∈ set.range f);
  • change the order of implicit arguments in the definition of set.inj_on;
  • add prod_filter_of_ne;
  • use coe instead of subtype.val in prod_attach;
  • add finset.image_subset_iff, finset.image_subset_iff_subset_preimage,
    finset.map_subset_iff_subset_preimage.

@urkud urkud added the awaiting-review The author would like community review of the PR label Jul 9, 2020
@kim-em
Copy link
Collaborator

kim-em commented Jul 12, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 12, 2020
bors bot pushed a commit that referenced this pull request Jul 12, 2020
…3342)

* rename `finset.prod_preimage` to `finset.prod_preimage_of_bij`;
* new `prod_preimage` assumes `∀ x ∈ s, x ∉ range f, g x = 1`;
* rename `finset.image_preimage` to `finset.image_preimage_of_bij`;
* new `finset.image_preimage` says
  `image f (preimage s hf) = s.filter (λ x, x ∈ set.range f)`;
* change the order of implicit arguments in the definition of `set.inj_on`;
* add `prod_filter_of_ne`;
* use `coe` instead of `subtype.val` in `prod_attach`;
* add `finset.image_subset_iff`, `finset.image_subset_iff_subset_preimage`,
  `finset.map_subset_iff_subset_preimage`.
@bors
Copy link

bors bot commented Jul 12, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/finite): add a version of prod_preimage for inj_on [Merged by Bors] - feat(data/set/finite): add a version of prod_preimage for inj_on Jul 12, 2020
@bors bors bot closed this Jul 12, 2020
@bors bors bot deleted the prod-preimage branch July 12, 2020 05:07
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…eanprover-community#3342)

* rename `finset.prod_preimage` to `finset.prod_preimage_of_bij`;
* new `prod_preimage` assumes `∀ x ∈ s, x ∉ range f, g x = 1`;
* rename `finset.image_preimage` to `finset.image_preimage_of_bij`;
* new `finset.image_preimage` says
  `image f (preimage s hf) = s.filter (λ x, x ∈ set.range f)`;
* change the order of implicit arguments in the definition of `set.inj_on`;
* add `prod_filter_of_ne`;
* use `coe` instead of `subtype.val` in `prod_attach`;
* add `finset.image_subset_iff`, `finset.image_subset_iff_subset_preimage`,
  `finset.map_subset_iff_subset_preimage`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants