This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/mv_polynomial/*): Simple • lemmas
#18084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
4 tasks
riccardobrasca
approved these changes
Jan 10, 2023
| @@ -419,6 +419,10 @@ by rw [X_pow_eq_monomial, support_monomial, if_neg (one_ne_zero' R)] | |||
|
|
|||
| @[simp] lemma support_zero : (0 : mv_polynomial σ R).support = ∅ := rfl | |||
|
|
|||
| lemma support_smul [distrib_mul_action R S₁] {a : R} {f : mv_polynomial σ S₁} : | |||
There was a problem hiding this comment.
I think a and f should be explicit here, unless you have a reason to keep them implicit.
There was a problem hiding this comment.
I am matching finsupp.support_smul, which has them implicit. And I am happy to keep it like that because I noticed that we tend to never use the explicit arguments of ≤, <, ⊆, ⊂ lemmas.
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
YaelDillies
commented
Jan 10, 2023
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
• lemmas• lemmas
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of missing lemmas about
a • fwherefis a multivariate polynomial.