Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting note: unimplemented has_nonempty_instance linter #12095

Closed
grunweg opened this issue Apr 12, 2024 · 1 comment
Closed

Porting note: unimplemented has_nonempty_instance linter #12095

grunweg opened this issue Apr 12, 2024 · 1 comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Comments

@grunweg
Copy link
Collaborator

grunweg commented Apr 12, 2024

This issue is tracking all porting notes referring to the has_nonempty_instance linter from mathlib3:
as this linter has not been ported to mathlib4 yet, the nolint entries from mathlib3 are commented. Porting notes look like

-- @[nolint has_nonempty_instance] -- Porting note: This linter does not exist yet.

Steps to fix

  • port the linter
  • see which of the previous nolints are required: uncomment the necessary ones and delete the now-superfluous ones.
    Remove the porting note in either case.
  • deal with any new errors in mathlib4
  • land the linter and rejoice :-)
@grunweg grunweg added porting-notes Mathlib3 to Mathlib4 porting notes. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Apr 12, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Apr 12, 2024

Closing in favour of #5171, oops.

@grunweg grunweg closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

No branches or pull requests

1 participant